lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <>
Subject [jira] [Issue Comment Deleted] (SOLR-12652) SolrMetricManager.overridableRegistryName should be removed; it doesn't work
Date Mon, 27 May 2019 15:19:00 GMT


Erick Erickson updated SOLR-12652:
    Comment: was deleted

(was: Commit 97e7d8a3d78779bb26148ed1849ba1acdf44c6c5 in lucene-solr's branch refs/heads/master
from Erick Erickson
[;h=97e7d8a ]

SOLR-12652: Clean up RealTimeGetComponent.toSolrDoc

> SolrMetricManager.overridableRegistryName should be removed; it doesn't work
> ----------------------------------------------------------------------------
>                 Key: SOLR-12652
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: 7.1
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 8.0
>         Attachments: SOLR-12652.patch, SOLR-12652.patch
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
> The {{SolrMetricManager.overridableRegistryName()}} method is a great idea but unfortunately
in practice I've found it doesn't really work; it seems fundamentally flawed.  +I wish it
could work+.  The main issue I think is that the callers of SMM.registerGauge/registerMetric
assumes it can place a gauge/metric and have it be the only once there (force==true).  But
it won't be if it's shared.  
> Another problem is in at least one of the reporters -- {{JmxMetricsReporter.JmxListener#registerMBean}}
will get in a race condition to remove an already-registered MBean but in the process of removing
it, it'll already get removed concurrently by some other core working on the same name.  This
results in {{}} logged as a warning; nothing serious.
 But I suspect conceptually there is a problem since which MBean should "win"?  Shrug.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message