lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stanislav Livotov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-12697) pure DocValues support for FieldValueFeature
Date Sat, 18 May 2019 00:12:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842814#comment-16842814
] 

Stanislav Livotov edited comment on SOLR-12697 at 5/18/19 12:11 AM:
--------------------------------------------------------------------

[~cpoerschke] agree that now we can remove {{FieldValueFeature.fieldAsSet}} and I don't see
a big difference where to store {{docFetcher}} and {{returnFields}} but we definitely can
do it, so I had moved it there. I had applied a new patch with these small changes.

I'm also not so well familiar with {{SolrDocumentFetcher}}, but documentation of the {{SolrDocumentFetcher#solrDoc}} is
telling that it is "_an optimized version for populating a SolrDocument_", and that it first
of all "_fetches all fields from docValues if possible_", and that's what I think we want
cause DV fields retrieving is faster.

[~erickerickson] do you mean that retrieving just 1 field from stored fields is not optimal?
Do you want to restrict it in this case? But it will be the change in behavior, cause previously
only retrieval from stored fields was supported(by using {{context.reader().document(itr.docID()}}). 


was (Author: slivotov):
[~cpoerschke] agree that now we can remove {{FieldValueFeature.fieldAsSet}} and I don't see
a big difference where to store {{docFetcher}} and {{returnFields}} but we definitely can
do it, so I had moved it there. I had applied a new patch with these small changes.

I'm also not so well familiar with {{SolrDocumentFetcher}}, but documentation of the {{SolrDocumentFetcher#solrDoc}} is
telling that it is "_an optimized version for populating a SolrDocument_", and that it first
of all "_fetches all fields from docValues if possible_", and that's what I think we want
cause DV fields retrieving is faster.

[~erickerickson] do you mean that retrieving just 1 field from stored fields is not optimal?
Do you want to restrict it in this case? But it will be the change in behavior, cause previously
only retrieval from stored fields was supported(by usingcontext.reader().document(itr.docID()). 

> pure DocValues support for FieldValueFeature
> --------------------------------------------
>
>                 Key: SOLR-12697
>                 URL: https://issues.apache.org/jira/browse/SOLR-12697
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: contrib - LTR
>            Reporter: Stanislav Livotov
>            Priority: Major
>         Attachments: SOLR-12697.patch, SOLR-12697.patch, SOLR-12697.patch, SOLR-12697.patch,
SOLR-12697.patch
>
>
> [~slivotov] wrote in SOLR-12688:
> bq. ... FieldValueFeature doesn't support pure DocValues fields (Stored false). Please
also note that for fields which are both stored and DocValues it is working not optimal because
it is extracting just one field from the stored document. DocValues are obviously faster for
such usecases. ...
> (Please see SOLR-12688 description for overall context and analysis results.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message