lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (JIRA) <j...@apache.org>
Subject [jira] [Updated] (SOLR-13352) possible deadlock/threadleak from OverseerTriggerThread/AutoScalingWatcher during close()
Date Thu, 16 May 2019 14:33:00 GMT

     [ https://issues.apache.org/jira/browse/SOLR-13352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jan Høydahl updated SOLR-13352:
-------------------------------
    Fix Version/s: 7.7.2

> possible deadlock/threadleak from OverseerTriggerThread/AutoScalingWatcher during close()
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-13352
>                 URL: https://issues.apache.org/jira/browse/SOLR-13352
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Major
>             Fix For: 7.7.2, 8.1, master (9.0)
>
>         Attachments: SOLR-13352.patch, sarowe_Lucene-Solr-tests-master_20462.log.txt
>
>
> A recent jenkins failure in TestSimTriggerIntegration lead me to what appears to be a
"lock leak" situation in OverseerTriggerThread in how the "updateLock" object is dealt with
in the event that the OverseerTriggerThread is closed.
> It's possible that this only affects tests using the SimCloudManager when calling "simRestartOverseer"
-- but 
> I _believe_ this can lead also lead to an actual deadlock / threadleak situation in a
thread running AutoScalingWatcher (that hold a refrefrences to OverseerTriggerThread and every
object reachable from it) when the OverseerTriggerThread is closed as part of a real Solr
shutdown ... which i think would cause the JVM to stall untill externally killed.
> ----
> If my analysis of the test failure (to follow in comment) is correct, then even even
if this bug isn't likely to affect real world solr instances (and only surfaces because of
how OverseerTriggerThread is used in SimCloudManager) the fix to OverseerTriggerThread is
a trivial change to follow locking best practices (patch to follow)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message