lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lucene/Solr QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12555) Replace try-fail-catch test patterns
Date Sun, 28 Jul 2019 20:08:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894787#comment-16894787
] 

Lucene/Solr QA commented on SOLR-12555:
---------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 113 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  5m 59s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  5m 59s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  5m 59s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  2m 
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green}  0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green}
 0m 37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 58s{color} | {color:green}
common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m  5s{color} | {color:green}
core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 40s{color} | {color:green}
join in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 28s{color} | {color:green}
queryparser in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 30s{color} | {color:green}
replicator in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 37s{color} | {color:green}
sandbox in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 25s{color} | {color:green}
suggest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m  7s{color} | {color:green}
test-framework in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 59s{color} | {color:green}
dataimporthandler in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 35s{color} | {color:green}
extraction in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  2s{color} | {color:green}
ltr in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 22s{color} | {color:red}
velocity in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 30m 57s{color} | {color:red}
core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  5m 17s{color} | {color:green}
solrj in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 30s{color} | {color:green}
test-framework in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 86m 14s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.search.facet.TestCloudJSONFacetSKG |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12555 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12976063/SOLR-12555.patch
|
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  validatesourcepatterns
 |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 8c8d8abddc |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| unit | https://builds.apache.org/job/PreCommit-SOLR-Build/512/artifact/out/patch-unit-solr_contrib_velocity.txt
|
| unit | https://builds.apache.org/job/PreCommit-SOLR-Build/512/artifact/out/patch-unit-solr_core.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/512/testReport/ |
| modules | C: lucene/analysis/common lucene/core lucene/join lucene/queryparser lucene/replicator
lucene/sandbox lucene/suggest lucene/test-framework solr/contrib/dataimporthandler solr/contrib/extraction
solr/contrib/ltr solr/contrib/velocity solr/core solr/solrj solr/test-framework U: . |
| Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/512/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Replace try-fail-catch test patterns
> ------------------------------------
>
>                 Key: SOLR-12555
>                 URL: https://issues.apache.org/jira/browse/SOLR-12555
>             Project: Solr
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 8.0
>            Reporter: Jason Gerlowski
>            Assignee: Jason Gerlowski
>            Priority: Trivial
>         Attachments: SOLR-12555-sorted-by-package.txt, SOLR-12555.patch, SOLR-12555.patch,
SOLR-12555.patch, SOLR-12555.patch, SOLR-12555.txt
>
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> I recently added some test code through SOLR-12427 which used the following test anti-pattern:
> {code}
> try {
>     actionExpectedToThrowException();
>     fail("I expected this to throw an exception, but it didn't");
> catch (Exception e) {
>     assertOnThrownException(e);
> }
> {code}
> Hoss (rightfully) objected that this should instead be written using the formulation
below, which is clearer and more concise.
> {code}
> SolrException e = expectThrows(() -> {...});
> {code}
> We should remove many of these older formulations where it makes sense.  Many of them
were written before {{expectThrows}} was introduced, and having the old style assertions around
makes it easier for them to continue creeping in.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message