lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
Date Tue, 02 Jul 2019 02:54:00 GMT


ASF subversion and git services commented on SOLR-13404:

Commit cfd22cd493d3b0feab8f582b6981cc05ee4f31a3 in lucene-solr's branch refs/heads/master
from Munendra S N
[;h=cfd22cd ]

SOLR-13404: support group.query in multishard env with group.main=true

group.query after execution forms QueryCommandResult. In case of
group.main=true or group.format=simple, QueryCommandResult was not
consumed in EndResultTransformer. Also, MainEndResultTransformer assumed
that always group.field would be specified. When group.field not specified
it failed with AIOOBE. After adding suppport for QueryCommandResult in
EndResultTransformers and handling AIOOBE, group.query started giving results

Working on tests exposed few other issues. Results differed b/w standalone
& distributed mode.
* One of the reason is that TopGroupShardResponseProcessor doesn't consider correct
  limit and offset when group format is simple. In case of simple, start and rows should be
  as limit and offset instead of group.limit and group.offset.
* Secondly, In distributed second phase grouping, computing docsToCollect didn't consider
  group response format. This issue is again similar to above issue
* offset(group.offset or start) not being considered during TopDocs#merge caused
  different results. The fix was to use to offset in merge process
* group.offset doesn't support negative values but there is no checks on the value.
  In case of negative values AIOOBE. Now, checks are added for negative values and
  returns proper error message(this change is for both standalone and distrbuted).
  Validation is done only in case of group.format=grouped as that is only case when
  group.offset is consumed.

Fixing above issues resolved the differences b/w standalone and distributed mode.

> group.query doesn't work in distrib mode when group.format=simple
> -----------------------------------------------------------------
>                 Key: SOLR-13404
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Munendra S N
>            Priority: Major
>         Attachments: SOLR-13404.patch, SOLR-13404.patch
> While working on SOLR-12248, found that for group.query response is returned only when
group.format=grouped(default format) in distrib mode. For group.main=true, request fails with
AIOOE and for group.format=simple, no grouped is returned

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message