lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tomoko Uchida (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8907) Provide backward compatibility for loading analysis factories
Date Wed, 10 Jul 2019 22:51:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882500#comment-16882500
] 

Tomoko Uchida commented on LUCENE-8907:
---------------------------------------

Hi,
I picked the commits which should be reverted from commit log mail. There are five commits:
all is mine and there is no conflicts other than lucene/CHANGES.txt on the reverted 8x branch.
All tests is OK and that passed precommit.

{code}
git revert 2804d00137957dc27dce922103c6286bbc7a9eca
git revert 7e05bd717309088d3b35cba6be0f70fd14b3c8d0
git revert d1678a3a68685acd1432dfadcd5f49fa817273ad
git revert 12e3451fb80e151b16f51493761b9dfc580f8fa0
git revert 0cc1753e76eb61000c1d3513448719e5f7923e48
{code}

I think we can delay the discussion about backporting LUCENE-8778 into 8.x with transparent
backwards compatibility. (From my perspective, the backporting to the 8x branch was my fault
and we do not need to change the SPI loader until release 9.0.)

> Provide backward compatibility for loading analysis factories
> -------------------------------------------------------------
>
>                 Key: LUCENE-8907
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8907
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: modules/analysis
>            Reporter: Tomoko Uchida
>            Assignee: Tomoko Uchida
>            Priority: Blocker
>             Fix For: 8.2
>
>
> The changes in LUCENE-8778 have breaking changes in the analysis factory interface and 
custom factories implemented by users / 3rd parties will be affected. We need to keep some
backwards compatibility during 8.x.
> Please see the discussion in SOLR-13593 for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message