lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Munendra S N (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13656) Fix SolrIndexConfigTest.testFailingSolrIndexConfigCreation
Date Sun, 28 Jul 2019 09:47:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894660#comment-16894660
] 

Munendra S N commented on SOLR-13656:
-------------------------------------

 [^SOLR-13656.patch] 

* Fixes the test 
* use expectThrows to verify
* remove DummyMergePolicy. This was added for tests and not used anywhere

> Fix SolrIndexConfigTest.testFailingSolrIndexConfigCreation
> ----------------------------------------------------------
>
>                 Key: SOLR-13656
>                 URL: https://issues.apache.org/jira/browse/SOLR-13656
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: Munendra S N
>            Assignee: Munendra S N
>            Priority: Major
>         Attachments: SOLR-13656.patch
>
>
> {{SolrIndexConfigTest.testFailingSolrIndexConfigCreation}} is added to test bad solrconfig
containing MergePolicyFactory without any public constructors.
> While working on SOLR-12555, found that above test fails while loading solrconfig instead
while creating mergepolicy



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message