lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Wöckinger (Jira) <j...@apache.org>
Subject [jira] [Commented] (SOLR-9505) Extra tests to confirm Atomic Update remove behaviour
Date Tue, 03 Sep 2019 14:29:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921463#comment-16921463
] 

Thomas Wöckinger commented on SOLR-9505:
----------------------------------------

The additional tests are working in master branch, when SOLR-13592 and SOLR-13539 are merged
to branch 8.x they should work there too

> Extra tests to confirm Atomic Update remove behaviour
> -----------------------------------------------------
>
>                 Key: SOLR-9505
>                 URL: https://issues.apache.org/jira/browse/SOLR-9505
>             Project: Solr
>          Issue Type: Test
>    Affects Versions: 7.0
>            Reporter: Tim Owen
>            Priority: Minor
>         Attachments: SOLR-9505.patch
>
>
> The behaviour of the Atomic Update {{remove}} operation in the code doesn't match the
description in the Confluence documentation, which has been questioned already. From looking
at the source code, and using curl to confirm, the {{remove}} operation only removes the first
occurrence of a value from a multi-valued field, it does not remove all occurrences. The {{removeregex}}
operation does remove all, however.
> There are unit tests for Atomic Updates, but they didn't assert this behaviour, so I've
added some extra assertions to confirm that, and a couple of extra tests including one that
checks that {{removeregex}} does a Regex match of the whole value, not just a find-anywhere
operation.
> I think it's the documentation that needs clarifying - the code behaves as expected (assuming
{{remove}} was intended to work that way?)



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message