lucene-java-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poeta simbolista <poetasimboli...@gmail.com>
Subject FieldCacheImpl code warning. String comparison not using equals
Date Wed, 14 Feb 2007 17:47:36 GMT

Hi guys,
I have been diving into the FieldCacheImpl code.
I have seen sth on actual version:
Revision 488908 - (view) (download) (annotate) - [select for diffs]
Modified Wed Dec 20 03:47:09 2006 UTC (8 weeks ago) by yonik
File length: 13425 byte(s) 

that I wonder if it's not totally right, or if it is, I would like to know
why.

In the creation of eeach cache (Int, Float, String) there is a String
comparison using != instead of equals method:

if (term==null || term.field() != field) break;

I hope this can be useful... though i have used the code and it seems to
work perfectly.
Cheers


-- 
View this message in context: http://www.nabble.com/FieldCacheImpl-code-warning.-String-comparison-not-using-equals-tf3228683.html#a8969965
Sent from the Lucene - Java Users mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org


Mime
View raw message