From commits-return-5379-apmail-lucenenet-commits-archive=lucenenet.apache.org@lucenenet.apache.org Sun Apr 2 07:06:02 2017 Return-Path: X-Original-To: apmail-lucenenet-commits-archive@www.apache.org Delivered-To: apmail-lucenenet-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4051B19CDC for ; Sun, 2 Apr 2017 07:06:02 +0000 (UTC) Received: (qmail 43326 invoked by uid 500); 2 Apr 2017 07:06:02 -0000 Delivered-To: apmail-lucenenet-commits-archive@lucenenet.apache.org Received: (qmail 43209 invoked by uid 500); 2 Apr 2017 07:06:02 -0000 Mailing-List: contact commits-help@lucenenet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: lucene-net-dev@lucenenet.apache.org Delivered-To: mailing list commits@lucenenet.apache.org Received: (qmail 43073 invoked by uid 99); 2 Apr 2017 07:06:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Apr 2017 07:06:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 83829E0896; Sun, 2 Apr 2017 07:06:01 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: nightowl888@apache.org To: commits@lucenenet.apache.org Date: Sun, 02 Apr 2017 07:06:04 -0000 Message-Id: In-Reply-To: <8cb7882a9a0844b1a19a5b0cff657b44@git.apache.org> References: <8cb7882a9a0844b1a19a5b0cff657b44@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [04/20] lucenenet git commit: Reviewed and removed some TODOs Reviewed and removed some TODOs Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/a8502e36 Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/a8502e36 Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/a8502e36 Branch: refs/heads/api-work Commit: a8502e36f852ef67ca943fc17866dd4f3fd9dbfc Parents: 4e54801 Author: Shad Storhaug Authored: Sun Apr 2 09:23:54 2017 +0700 Committer: Shad Storhaug Committed: Sun Apr 2 09:23:54 2017 +0700 ---------------------------------------------------------------------- .../Codecs/Lucene42/Lucene42DocValuesProducer.cs | 2 +- .../Search/ControlledRealTimeReopenThread.cs | 2 +- .../Analysis/MockTokenizer.cs | 18 +++++++++--------- .../Codecs/Lucene40/Lucene40DocValuesWriter.cs | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a8502e36/src/Lucene.Net.Core/Codecs/Lucene42/Lucene42DocValuesProducer.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Core/Codecs/Lucene42/Lucene42DocValuesProducer.cs b/src/Lucene.Net.Core/Codecs/Lucene42/Lucene42DocValuesProducer.cs index 010adb0..4503588 100644 --- a/src/Lucene.Net.Core/Codecs/Lucene42/Lucene42DocValuesProducer.cs +++ b/src/Lucene.Net.Core/Codecs/Lucene42/Lucene42DocValuesProducer.cs @@ -290,7 +290,7 @@ namespace Lucene.Net.Codecs.Lucene42 return new NumericDocValuesAnonymousInnerClassHelper3(min, mult, quotientReader); default: - throw new InvalidOperationException(); // LUCENENET TODO: This was AssertionError in Lucene - does this need a fix? + throw new InvalidOperationException(); } } http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a8502e36/src/Lucene.Net.Core/Search/ControlledRealTimeReopenThread.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Core/Search/ControlledRealTimeReopenThread.cs b/src/Lucene.Net.Core/Search/ControlledRealTimeReopenThread.cs index ccdffa9..34f4f9a 100644 --- a/src/Lucene.Net.Core/Search/ControlledRealTimeReopenThread.cs +++ b/src/Lucene.Net.Core/Search/ControlledRealTimeReopenThread.cs @@ -117,7 +117,7 @@ namespace Lucene.Net.Search reopenCond.Reset(); } - public void Dispose() // LUCENENET TODO: Implement disposable pattern + public void Dispose() { finish = true; reopenCond.Set(); http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a8502e36/src/Lucene.Net.TestFramework/Analysis/MockTokenizer.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.TestFramework/Analysis/MockTokenizer.cs b/src/Lucene.Net.TestFramework/Analysis/MockTokenizer.cs index e557eee..2889557 100644 --- a/src/Lucene.Net.TestFramework/Analysis/MockTokenizer.cs +++ b/src/Lucene.Net.TestFramework/Analysis/MockTokenizer.cs @@ -257,15 +257,15 @@ namespace Lucene.Net.Analysis int ret = m_input.Read(c, 1, 1); return ret <= 0 ? -1 : c[1]; } - /* LUCENE TO-DO not sure if needed, CharBuffer not supported - case 2: - { - // read(CharBuffer) - char[] c = new char[1]; - CharBuffer cb = CharBuffer.Wrap(c); - int ret = Input.Read(cb); - return ret < 0 ? ret : c[0]; - }*/ + // LUCENENET NOTE: CharBuffer not supported + //case 2: + // { + // // read(CharBuffer) + // char[] c = new char[1]; + // CharBuffer cb = CharBuffer.Wrap(c); + // int ret = m_input.Read(cb); + // return ret < 0 ? ret : c[0]; + // } default: // read() return m_input.Read(); http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a8502e36/src/Lucene.Net.TestFramework/Codecs/Lucene40/Lucene40DocValuesWriter.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.TestFramework/Codecs/Lucene40/Lucene40DocValuesWriter.cs b/src/Lucene.Net.TestFramework/Codecs/Lucene40/Lucene40DocValuesWriter.cs index 51c4b36..18b157f 100644 --- a/src/Lucene.Net.TestFramework/Codecs/Lucene40/Lucene40DocValuesWriter.cs +++ b/src/Lucene.Net.TestFramework/Codecs/Lucene40/Lucene40DocValuesWriter.cs @@ -73,7 +73,7 @@ namespace Lucene.Net.Codecs.Lucene40 // fits in a byte[], would be more than 4bpv, just write byte[] AddBytesField(field, data, values); } - else if (minValue >= short.MinValue && maxValue <= short.MaxValue && PackedInt32s.BitsRequired(maxValue - minValue) > 8) // LUCENENET TODO: Shouldn't this be ushort.MinValue & MaxValue? + else if (minValue >= short.MinValue && maxValue <= short.MaxValue && PackedInt32s.BitsRequired(maxValue - minValue) > 8) { // fits in a short[], would be more than 8bpv, just write short[] AddShortsField(field, data, values);