lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject lucenenet git commit: Lucene.Net.Tests.Benchmark.ByTask.TestPerfTasksLogic.TestCollator(): Changed culture from no-NO to nb-NO to ensure it runs consistently between dev and the CI server.
Date Thu, 14 Sep 2017 00:47:00 GMT
Repository: lucenenet
Updated Branches:
  refs/heads/master 302ab8c4c -> 0aac3702f


Lucene.Net.Tests.Benchmark.ByTask.TestPerfTasksLogic.TestCollator(): Changed culture from
no-NO to nb-NO to ensure it runs consistently between dev and the CI server.


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/0aac3702
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/0aac3702
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/0aac3702

Branch: refs/heads/master
Commit: 0aac3702fbbdd570848573ae8caed4ab010c04cf
Parents: 302ab8c
Author: Shad Storhaug <shad@shadstorhaug.com>
Authored: Thu Sep 14 07:46:49 2017 +0700
Committer: Shad Storhaug <shad@shadstorhaug.com>
Committed: Thu Sep 14 07:46:49 2017 +0700

----------------------------------------------------------------------
 .../ByTask/TestPerfTasksLogic.cs                      | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/0aac3702/src/Lucene.Net.Tests.Benchmark/ByTask/TestPerfTasksLogic.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Tests.Benchmark/ByTask/TestPerfTasksLogic.cs b/src/Lucene.Net.Tests.Benchmark/ByTask/TestPerfTasksLogic.cs
index 8448fc8..a658026 100644
--- a/src/Lucene.Net.Tests.Benchmark/ByTask/TestPerfTasksLogic.cs
+++ b/src/Lucene.Net.Tests.Benchmark/ByTask/TestPerfTasksLogic.cs
@@ -977,6 +977,7 @@ namespace Lucene.Net.Benchmarks.ByTask
             // specify language + country + variant
             //benchmark = execBenchmark(getLocaleConfig("no,NO,NY"));
             //assertEquals(new CultureInfo("no-NO"/*, "NY"*/), benchmark.RunData.Locale);
+
             // LUCENENET specific - in .NET Norwegian is specified as either nb-NO (Bokmål)
or 
             // nn-NO (Nynorsk) + a few other dialects. no-NO works sometimes, but is not
             // supported across all OS's, so doesn't make a reliable test case.
@@ -1031,9 +1032,18 @@ namespace Lucene.Net.Benchmarks.ByTask
             expected = new ICUCollationKeyAnalyzer(TEST_VERSION_CURRENT, Collator.Create(new
CultureInfo("en-US"), Collator.Fallback.FallbackAllowed));
             assertEqualCollation(expected, benchmark.RunData.Analyzer, "foobar");
 
+            //// specify language + country + variant
+            //benchmark = execBenchmark(getCollatorConfig("no,NO,NY", collatorParam));
+            //expected = new ICUCollationKeyAnalyzer(TEST_VERSION_CURRENT, Collator.Create(new
CultureInfo("no-NO"/*, "NY"*/), Collator.Fallback.FallbackAllowed));
+            //assertEqualCollation(expected, benchmark.RunData.Analyzer, "foobar");
+
+            // LUCENENET specific - in .NET Norwegian is specified as either nb-NO (Bokmål)
or 
+            // nn-NO (Nynorsk) + a few other dialects. no-NO works sometimes, but is not
+            // supported across all OS's, so doesn't make a reliable test case.
+
             // specify language + country + variant
-            benchmark = execBenchmark(getCollatorConfig("no,NO,NY", collatorParam));
-            expected = new ICUCollationKeyAnalyzer(TEST_VERSION_CURRENT, Collator.Create(new
CultureInfo("no-NO"/*, "NY"*/), Collator.Fallback.FallbackAllowed));
+            benchmark = execBenchmark(getCollatorConfig("nb,NO,NY", collatorParam));
+            expected = new ICUCollationKeyAnalyzer(TEST_VERSION_CURRENT, Collator.Create(new
CultureInfo("nb-NO"/*, "NY"*/), Collator.Fallback.FallbackAllowed));
             assertEqualCollation(expected, benchmark.RunData.Analyzer, "foobar");
         }
 


Mime
View raw message