lucy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mar...@apache.org
Subject [lucy-commits] svn commit: r1183780 - in /incubator/lucy/branches/clownfish_lemon/clownfish/t: 102-integer_type.t 103-float_type.t 104-void_type.t 106-va_list_type.t
Date Sun, 16 Oct 2011 01:35:46 GMT
Author: marvin
Date: Sun Oct 16 01:35:45 2011
New Revision: 1183780

URL: http://svn.apache.org/viewvc?rev=1183780&view=rev
Log:
The addition of the IDENTIFIER token has made it so Lex will now prefer to
parse e.g. "voidable" as an IDENTIFIER rather than as "void" "able".  This
makes some TODO tests pass, so remove their TODOs.

Modified:
    incubator/lucy/branches/clownfish_lemon/clownfish/t/102-integer_type.t
    incubator/lucy/branches/clownfish_lemon/clownfish/t/103-float_type.t
    incubator/lucy/branches/clownfish_lemon/clownfish/t/104-void_type.t
    incubator/lucy/branches/clownfish_lemon/clownfish/t/106-va_list_type.t

Modified: incubator/lucy/branches/clownfish_lemon/clownfish/t/102-integer_type.t
URL: http://svn.apache.org/viewvc/incubator/lucy/branches/clownfish_lemon/clownfish/t/102-integer_type.t?rev=1183780&r1=1183779&r2=1183780&view=diff
==============================================================================
--- incubator/lucy/branches/clownfish_lemon/clownfish/t/102-integer_type.t (original)
+++ incubator/lucy/branches/clownfish_lemon/clownfish/t/102-integer_type.t Sun Oct 16 01:35:45
2011
@@ -57,12 +57,9 @@ for my $chy_specifier (@chy_specifiers) 
     isa_ok( $type, "Clownfish::Type" );
     ok( $type && $type->is_integer, "parsed const Type is_integer()" );
     ok( $type && $type->const,      "parsed const Type is const()" );
-    TODO: {
-        local $TODO = "No word boundaries in lex";
-        my $bogus = $chy_specifier . "oot_toot";
-        ok( !$parser->parse($bogus),
-            "chy_integer_specifier guards against partial word matches" );
-    }
+    my $bogus = $chy_specifier . "oot_toot";
+    ok( !$parser->parse($bogus),
+        "chy_integer_specifier guards against partial word matches" );
 }
 
 for my $c_specifier (@c_specifiers) {
@@ -73,10 +70,7 @@ for my $c_specifier (@c_specifiers) {
     isa_ok( $type, "Clownfish::Type" );
     ok( $type && $type->is_integer, "parsed const Type is_integer()" );
     ok( $type && $type->const,      "parsed const Type is const()" );
-    TODO: {
-        local $TODO = "No word boundaries in lex";
-        my $bogus = $c_specifier . "y";
-        ok( !$parser->parse($bogus),
-            "c_integer_specifier guards against partial word matches" );
-    }
+    my $bogus = $c_specifier . "y";
+    ok( !$parser->parse($bogus),
+        "c_integer_specifier guards against partial word matches" );
 }

Modified: incubator/lucy/branches/clownfish_lemon/clownfish/t/103-float_type.t
URL: http://svn.apache.org/viewvc/incubator/lucy/branches/clownfish_lemon/clownfish/t/103-float_type.t?rev=1183780&r1=1183779&r2=1183780&view=diff
==============================================================================
--- incubator/lucy/branches/clownfish_lemon/clownfish/t/103-float_type.t (original)
+++ incubator/lucy/branches/clownfish_lemon/clownfish/t/103-float_type.t Sun Oct 16 01:35:45
2011
@@ -40,10 +40,7 @@ for my $specifier (qw( float double)) {
     ok( $type && $type->const,       "parsed const specifier is_floating()" );
     my $bogus = $specifier . "y";
 
-    TODO: {
-        local $TODO = "No word boundary support in lex";
-        ok( !$parser->parse($bogus),
-            "c_float_specifier guards against partial word matches" );
-    }
+    ok( !$parser->parse($bogus),
+        "c_float_specifier guards against partial word matches" );
 }
 

Modified: incubator/lucy/branches/clownfish_lemon/clownfish/t/104-void_type.t
URL: http://svn.apache.org/viewvc/incubator/lucy/branches/clownfish_lemon/clownfish/t/104-void_type.t?rev=1183780&r1=1183779&r2=1183780&view=diff
==============================================================================
--- incubator/lucy/branches/clownfish_lemon/clownfish/t/104-void_type.t (original)
+++ incubator/lucy/branches/clownfish_lemon/clownfish/t/104-void_type.t Sun Oct 16 01:35:45
2011
@@ -44,9 +44,6 @@ ok( $const_void_type && $const_void_type
     "Parser preserves const when parsing 'const void'"
 );
 
-TODO: {
-    local $TODO = "no word boundary detection by lex";
-    ok( !$parser->parse('voidable'),
-        "void_type_specifier guards against partial word matches" );
-}
+ok( !$parser->parse('voidable'),
+    "void_type_specifier guards against partial word matches" );
 

Modified: incubator/lucy/branches/clownfish_lemon/clownfish/t/106-va_list_type.t
URL: http://svn.apache.org/viewvc/incubator/lucy/branches/clownfish_lemon/clownfish/t/106-va_list_type.t?rev=1183780&r1=1183779&r2=1183780&view=diff
==============================================================================
--- incubator/lucy/branches/clownfish_lemon/clownfish/t/106-va_list_type.t (original)
+++ incubator/lucy/branches/clownfish_lemon/clownfish/t/106-va_list_type.t Sun Oct 16 01:35:45
2011
@@ -29,10 +29,7 @@ my $parser = Clownfish::Parser->new;
 
 my $type = $parser->parse('va_list');
 ok( $type && $type->is_va_list, "parse va_list" );
-TODO: {
-    local $TODO = "No word boundaries in lex";
-    ok( !$parser->parse('va_listable'),
-        "va_list_type_specifier guards against partial word matches"
-    );
-}
+ok( !$parser->parse('va_listable'),
+    "va_list_type_specifier guards against partial word matches"
+);
 



Mime
View raw message