lucy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nwelln...@apache.org
Subject [lucy-commits] [3/6] git commit: MSVC flags shouldn't be needed for XS compilation
Date Sun, 16 Feb 2014 23:20:04 GMT
MSVC flags shouldn't be needed for XS compilation


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/9904253b
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/9904253b
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/9904253b

Branch: refs/heads/cflags
Commit: 9904253be8aa0e869ab1b10a414809256c353919
Parents: a130e81
Author: Nick Wellnhofer <wellnhofer@aevum.de>
Authored: Sun Feb 16 22:11:22 2014 +0100
Committer: Nick Wellnhofer <wellnhofer@aevum.de>
Committed: Mon Feb 17 00:18:42 2014 +0100

----------------------------------------------------------------------
 compiler/perl/lib/Clownfish/CFC/Perl/Build.pm | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/9904253b/compiler/perl/lib/Clownfish/CFC/Perl/Build.pm
----------------------------------------------------------------------
diff --git a/compiler/perl/lib/Clownfish/CFC/Perl/Build.pm b/compiler/perl/lib/Clownfish/CFC/Perl/Build.pm
index 8316c8e..eef8621 100644
--- a/compiler/perl/lib/Clownfish/CFC/Perl/Build.pm
+++ b/compiler/perl/lib/Clownfish/CFC/Perl/Build.pm
@@ -58,16 +58,8 @@ my $BUILDLIB_DIR = 'buildlib';
 sub new {
     my $self = shift->SUPER::new( @_ );
 
-    my $extra_ccflags = $self->extra_compiler_flags;
-    if ( $self->config('cc') =~ /^cl\b/ ) {
-        # Compile as C++ under MSVC.
-        push @$extra_ccflags, qw(
-            -TP -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS
-        );
-        # Redefine 'for' to fix broken 'for' scoping under MSVC6.
-        push @$extra_ccflags, '-Dfor="if(0);else for"';
-    }
     # Define HAS_BOOL, so that the Perl headers don't redefine 'bool'.
+    my $extra_ccflags = $self->extra_compiler_flags;
     push @$extra_ccflags, '-DHAS_BOOL';
     $self->extra_compiler_flags(@$extra_ccflags);
 


Mime
View raw message