lucy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nwelln...@apache.org
Subject [lucy-commits] git commit: Comments on indirect dependencies
Date Tue, 18 Mar 2014 17:42:35 GMT
Repository: lucy-clownfish
Updated Branches:
  refs/heads/single-parcel-per-file ba106eb22 -> edf1653f8


Comments on indirect dependencies


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/edf1653f
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/edf1653f
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/edf1653f

Branch: refs/heads/single-parcel-per-file
Commit: edf1653f835bab6c0271f2804c65b6944bce9cd7
Parents: ba106eb
Author: Nick Wellnhofer <wellnhofer@aevum.de>
Authored: Tue Mar 18 18:41:16 2014 +0100
Committer: Nick Wellnhofer <wellnhofer@aevum.de>
Committed: Tue Mar 18 18:41:16 2014 +0100

----------------------------------------------------------------------
 compiler/src/CFCParcel.c      | 3 +++
 compiler/src/CFCPerl.c        | 1 -
 compiler/src/CFCPerlTypeMap.c | 2 --
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/edf1653f/compiler/src/CFCParcel.c
----------------------------------------------------------------------
diff --git a/compiler/src/CFCParcel.c b/compiler/src/CFCParcel.c
index 3050613..fd424f4 100644
--- a/compiler/src/CFCParcel.c
+++ b/compiler/src/CFCParcel.c
@@ -480,6 +480,9 @@ CFCParcel_prereq_parcels(CFCParcel *self) {
 void
 CFCParcel_check_prereqs(CFCParcel *self) {
     // This is essentially a depth-first search of the dependency graph.
+    // It might be possible to skip indirect dependencies, at least if
+    // they're not part of the inheritance chain. But for now, all
+    // dependencies are marked recursively.
 
     if (self->is_required) { return; }
     self->is_required = true;

http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/edf1653f/compiler/src/CFCPerl.c
----------------------------------------------------------------------
diff --git a/compiler/src/CFCPerl.c b/compiler/src/CFCPerl.c
index 9447c76..dbde5e5 100644
--- a/compiler/src/CFCPerl.c
+++ b/compiler/src/CFCPerl.c
@@ -404,7 +404,6 @@ CFCPerl_write_bindings(CFCPerl *self) {
     // Pound-includes for generated headers.
     for (size_t i = 0; ordered[i] != NULL; i++) {
         CFCClass *klass = ordered[i];
-        // It might be possible to skip indirect dependencies here.
         const char *include_h = CFCClass_include_h(klass);
         generated_xs = CFCUtil_cat(generated_xs, "#include \"", include_h,
                                    "\"\n", NULL);

http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/edf1653f/compiler/src/CFCPerlTypeMap.c
----------------------------------------------------------------------
diff --git a/compiler/src/CFCPerlTypeMap.c b/compiler/src/CFCPerlTypeMap.c
index ddba4a4..c7d513d 100644
--- a/compiler/src/CFCPerlTypeMap.c
+++ b/compiler/src/CFCPerlTypeMap.c
@@ -264,8 +264,6 @@ CFCPerlTypeMap_write_xs_typemap(CFCHierarchy *hierarchy) {
     char *output = CFCUtil_strdup("");
     for (int i = 0; classes[i] != NULL; i++) {
         CFCClass *klass = classes[i];
-        // It might be possible to skip indirect dependencies here.
-
         const char *full_struct_sym = CFCClass_full_struct_sym(klass);
         const char *vtable_var      = CFCClass_full_vtable_var(klass);
 


Mime
View raw message