lucy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mar...@apache.org
Subject [lucy-commits] [31/54] [abbrv] git commit: refs/heads/sortex_ptr_only - Switch to Module::Build->depends_on
Date Sat, 26 Apr 2014 23:12:01 GMT
Switch to Module::Build->depends_on

According to the Module::Build documentation, 'depends_on' is preferred
over 'dispatch' when calling actions from inside another action.


Project: http://git-wip-us.apache.org/repos/asf/lucy/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy/commit/340d6910
Tree: http://git-wip-us.apache.org/repos/asf/lucy/tree/340d6910
Diff: http://git-wip-us.apache.org/repos/asf/lucy/diff/340d6910

Branch: refs/heads/sortex_ptr_only
Commit: 340d6910e55f56c9c3bc6f7ea68e6ca1827eb668
Parents: f333df0
Author: Nick Wellnhofer <wellnhofer@aevum.de>
Authored: Sat Aug 17 16:54:49 2013 +0200
Committer: Nick Wellnhofer <wellnhofer@aevum.de>
Committed: Tue Apr 22 21:28:58 2014 +0200

----------------------------------------------------------------------
 perl/buildlib/Lucy/Build.pm | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy/blob/340d6910/perl/buildlib/Lucy/Build.pm
----------------------------------------------------------------------
diff --git a/perl/buildlib/Lucy/Build.pm b/perl/buildlib/Lucy/Build.pm
index cf82aa1..1118474 100644
--- a/perl/buildlib/Lucy/Build.pm
+++ b/perl/buildlib/Lucy/Build.pm
@@ -85,7 +85,7 @@ sub ACTION_lemon {
 sub ACTION_copy_clownfish_includes {
     my $self = shift;
 
-    $self->dispatch('charmony');
+    $self->depends_on('charmony');
 
     $self->SUPER::ACTION_copy_clownfish_includes;
 
@@ -95,7 +95,7 @@ sub ACTION_copy_clownfish_includes {
 sub ACTION_clownfish {
     my $self = shift;
 
-    $self->dispatch('charmony');
+    $self->depends_on('charmony');
 
     $self->SUPER::ACTION_clownfish;
 }
@@ -162,8 +162,7 @@ sub ACTION_test_valgrind {
     if ( !$ENV{LUCY_VALGRIND} ) {
         warn "\$ENV{LUCY_VALGRIND} not true -- possible false positives";
     }
-    $self->dispatch('code');
-    $self->dispatch('suppressions');
+    $self->depends_on(qw( code suppressions ));
 
     # Unbuffer STDOUT, grab test file names and suppressions files.
     $|++;
@@ -218,7 +217,7 @@ sub ACTION_test_valgrind {
 # Run all .y files through lemon.
 sub ACTION_parsers {
     my $self = shift;
-    $self->dispatch('lemon');
+    $self->depends_on('lemon');
     my $y_files = $self->rscan_dir( $CORE_SOURCE_DIR, qr/\.y$/ );
     for my $y_file (@$y_files) {
         my $c_file = $y_file;
@@ -234,7 +233,7 @@ sub ACTION_parsers {
 sub ACTION_compile_custom_xs {
     my $self = shift;
 
-    $self->dispatch('parsers');
+    $self->depends_on('parsers');
 
     $self->SUPER::ACTION_compile_custom_xs;
 }
@@ -285,7 +284,7 @@ sub ACTION_dist {
     _check_module_build_for_dist;
 
     # Create POD but make sure not to include build artifacts.
-    $self->dispatch('pod');
+    $self->depends_on('pod');
     _clean_prereq_builds($self);
 
     # We build our Perl release tarball from $REPOS_ROOT/perl, rather than
@@ -312,7 +311,7 @@ sub ACTION_dist {
         system("cp -R ../$item $item");
     }
 
-    $self->dispatch('manifest');
+    $self->depends_on('manifest');
     my $no_index = $self->_gen_pause_exclusion_list;
     my $meta_add = $self->meta_add || {};
     $meta_add->{no_index} = $no_index;


Mime
View raw message