lucy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mar...@apache.org
Subject [7/7] git commit: Fix mixed decs and code in custom XS.
Date Sun, 20 Jul 2014 18:56:12 GMT
Fix mixed decs and code in custom XS.


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/6f2a0a19
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/6f2a0a19
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/6f2a0a19

Branch: refs/heads/master
Commit: 6f2a0a193a5ce0d9b9a4173b7a0a0b64bd485f51
Parents: 7511243
Author: Marvin Humphrey <marvin@rectangular.com>
Authored: Sun Jul 20 19:50:33 2014 +0100
Committer: Marvin Humphrey <marvin@rectangular.com>
Committed: Sun Jul 20 19:54:49 2014 +0100

----------------------------------------------------------------------
 runtime/perl/buildlib/Clownfish/Build/Binding.pm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/6f2a0a19/runtime/perl/buildlib/Clownfish/Build/Binding.pm
----------------------------------------------------------------------
diff --git a/runtime/perl/buildlib/Clownfish/Build/Binding.pm b/runtime/perl/buildlib/Clownfish/Build/Binding.pm
index 01f87f8..f249aed 100644
--- a/runtime/perl/buildlib/Clownfish/Build/Binding.pm
+++ b/runtime/perl/buildlib/Clownfish/Build/Binding.pm
@@ -569,12 +569,12 @@ fetch_class(unused_sv, class_name_sv)
     SV *class_name_sv;
 CODE:
 {
-    CFISH_UNUSED_VAR(unused_sv);
     STRLEN size;
     char *ptr = SvPVutf8(class_name_sv, size);
     cfish_StackString *class_name = CFISH_SSTR_WRAP_UTF8(ptr, size);
     cfish_Class *klass
         = cfish_Class_fetch_class((cfish_String*)class_name);
+    CFISH_UNUSED_VAR(unused_sv);
     RETVAL = klass ? (SV*)CFISH_Class_To_Host(klass) : &PL_sv_undef;
 }
 OUTPUT: RETVAL
@@ -584,9 +584,9 @@ singleton(unused_sv, ...)
     SV *unused_sv;
 CODE:
 {
-    CFISH_UNUSED_VAR(unused_sv);
     cfish_String *class_name = NULL;
     cfish_Class  *parent     = NULL;
+    cfish_Class  *singleton  = NULL;
     bool args_ok
         = XSBind_allot_params(&(ST(0)), 1, items,
                               ALLOT_OBJ(&class_name, "class_name", 10, true,
@@ -594,10 +594,11 @@ CODE:
                               ALLOT_OBJ(&parent, "parent", 6, false,
                                         CFISH_CLASS, NULL),
                               NULL);
+    CFISH_UNUSED_VAR(unused_sv);
     if (!args_ok) {
         CFISH_RETHROW(CFISH_INCREF(cfish_Err_get_error()));
     }
-    cfish_Class *singleton = cfish_Class_singleton(class_name, parent);
+    singleton = cfish_Class_singleton(class_name, parent);
     RETVAL = (SV*)CFISH_Class_To_Host(singleton);
 }
 OUTPUT: RETVAL


Mime
View raw message