lucy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nwelln...@apache.org
Subject [1/2] git commit: Adjust test for Storable leak
Date Thu, 17 Jul 2014 15:19:21 GMT
Repository: lucy-clownfish
Updated Branches:
  refs/heads/master b033b5223 -> e68aa863e


Adjust test for Storable leak

Some versions of Storable seem to leak when dying in a freeze hook
(see RT #97316). Create an extra object for the freeze test so that
subsequent tests won't be confused by an increased refcount.


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/eefe7052
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/eefe7052
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/eefe7052

Branch: refs/heads/master
Commit: eefe7052c49bb81e9ee9cc5b7c219010cd17fa53
Parents: b033b52
Author: Nick Wellnhofer <wellnhofer@aevum.de>
Authored: Thu Jul 17 16:55:39 2014 +0200
Committer: Nick Wellnhofer <wellnhofer@aevum.de>
Committed: Thu Jul 17 16:55:39 2014 +0200

----------------------------------------------------------------------
 runtime/perl/t/binding/019-obj.t | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/eefe7052/runtime/perl/t/binding/019-obj.t
----------------------------------------------------------------------
diff --git a/runtime/perl/t/binding/019-obj.t b/runtime/perl/t/binding/019-obj.t
index ce9e9d9..32b2e16 100644
--- a/runtime/perl/t/binding/019-obj.t
+++ b/runtime/perl/t/binding/019-obj.t
@@ -56,7 +56,8 @@ isa_ok( $object, "Clownfish::Obj",
 
 {
     no warnings 'once';
-    eval { freeze($object) };
+    my $thawed = TestObj->new;
+    eval { freeze($thawed) };
     like( $@, qr/implement/i,
         "freezing an Obj throws an exception rather than segfaults" );
     *TestObj::STORABLE_freeze = sub {"meep"};


Mime
View raw message