lucy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nwelln...@apache.org
Subject lucy git commit: Don't thaw Booleans under valgrind
Date Tue, 01 Mar 2016 15:45:10 GMT
Repository: lucy
Updated Branches:
  refs/heads/master e1b4fb269 -> 243988811


Don't thaw Booleans under valgrind

This is known to leak.


Project: http://git-wip-us.apache.org/repos/asf/lucy/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy/commit/24398881
Tree: http://git-wip-us.apache.org/repos/asf/lucy/tree/24398881
Diff: http://git-wip-us.apache.org/repos/asf/lucy/diff/24398881

Branch: refs/heads/master
Commit: 24398881171deeb035dfecb41400236b48de789b
Parents: e1b4fb2
Author: Nick Wellnhofer <wellnhofer@aevum.de>
Authored: Tue Mar 1 16:44:31 2016 +0100
Committer: Nick Wellnhofer <wellnhofer@aevum.de>
Committed: Tue Mar 1 16:44:31 2016 +0100

----------------------------------------------------------------------
 core/Lucy/Test/Util/TestFreezer.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy/blob/24398881/core/Lucy/Test/Util/TestFreezer.c
----------------------------------------------------------------------
diff --git a/core/Lucy/Test/Util/TestFreezer.c b/core/Lucy/Test/Util/TestFreezer.c
index 2f229ee..2cfba78 100644
--- a/core/Lucy/Test/Util/TestFreezer.c
+++ b/core/Lucy/Test/Util/TestFreezer.c
@@ -123,14 +123,19 @@ test_num(TestBatchRunner *runner) {
     Integer *i64 = Int_new(-1);
     Float   *f64_thaw = (Float*)S_freeze_thaw((Obj*)f64);
     Integer *i64_thaw = (Integer*)S_freeze_thaw((Obj*)i64);
-    Boolean   *true_thaw = (Boolean*)S_freeze_thaw((Obj*)CFISH_TRUE);
 
     TEST_TRUE(runner, Float_Equals(f64, (Obj*)f64_thaw),
               "Float freeze/thaw");
     TEST_TRUE(runner, Int_Equals(i64, (Obj*)i64_thaw),
               "Integer freeze/thaw");
+
+#ifdef LUCY_VALGRIND
+    SKIP(runner, 1, "known leaks");
+#else
+    Boolean *true_thaw = (Boolean*)S_freeze_thaw((Obj*)CFISH_TRUE);
     TEST_TRUE(runner, Bool_Equals(CFISH_TRUE, (Obj*)true_thaw),
               "Boolean freeze/thaw");
+#endif
 
     DECREF(i64_thaw);
     DECREF(f64_thaw);


Mime
View raw message