lucy-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marvin Humphrey (Commented) (JIRA)" <j...@apache.org>
Subject [lucy-issues] [jira] [Commented] (LUCY-204) Process ClusterSearcher RPCs in parallel
Date Fri, 23 Dec 2011 02:31:30 GMT

    [ https://issues.apache.org/jira/browse/LUCY-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175237#comment-13175237
] 

Marvin Humphrey commented on LUCY-204:
--------------------------------------

It's great to see this!

Some comments:

  * Very nice work integrating the callbacks with the select.
  * I like the refactoring you've done around the shards.  It's clear how
    you're handling the incomplete buffers (and it's better than what I'd had
    in mind).
  * The "Blocking" argument to IO::Socket::INET#new is still commented out.
    If I uncomment "Blocking", the tests still pass.  However, we had a
    situation before where the tests passed before yet users encountered
    errors -- see <http://markmail.org/message/66iwazc6fho3tvy2>.  Our current
    tests are not sufficient as they do not trigger partial writes and reads.
  * I believe that send/recv are for UDP packets and that we should be
    using syswrite/sysread.  Tests still pass when they are swapped out.
  * I'd advocate using confess() instead of die, so that we get a full stack
    trace to work with.

+1 to commit this even without tests for incomplete reads/writes (though I
think changing to syswrite/sysread is important).  If it turns out to have
problems, we'll just make a bugfix release.  This patch is a great step
forwards!

                
> Process ClusterSearcher RPCs in parallel
> ----------------------------------------
>
>                 Key: LUCY-204
>                 URL: https://issues.apache.org/jira/browse/LUCY-204
>             Project: Lucy
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Nick Wellnhofer
>            Assignee: Nick Wellnhofer
>         Attachments: LUCY-204.patch
>
>
> The ClusterSearcher should process "multi" RPCs to the shards in parallel. This should
speed things up and release connections to the SearchServers earlier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message