lucy-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [lucy-issues] [jira] [Commented] (CLOWNFISH-32) Autogenerate Go binding code
Date Wed, 15 Jul 2015 00:57:04 GMT


ASF GitHub Bot commented on CLOWNFISH-32:

GitHub user rectang opened a pull request:

    CLOWNFISH-32 Go constructor autogen

    Autogenerate Go constructor bindings.
    The constructors follow Go naming conventions, following the proof-of-concept bindings:
    Subtyping is not supported.  Under the hood, we use the inert function `new` when available
-- unlike the Perl bindings, which use `init`.

You can merge this pull request into a Git repository by running:

    $ git pull CLOWNFISH-32-go-ctor-autogen

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
commit fffd970490b37a1c53cdef0afa78272aee9dc2eb
Author: Marvin Humphrey <>
Date:   2015-07-11T23:01:41Z

    Add placeholder for generated constructors.

commit 3f6266df84139f93812015400e67f64d2eb733f6
Author: Marvin Humphrey <>
Date:   2015-07-14T00:21:14Z

    Generalize Go-to-cfish arg list prep.
    Make the functionality which converts Go argument lists to
    Clownfish-flavored-C argument lists more widely available.

commit 858fa345086d119f750544449ba78a8545603860
Author: Marvin Humphrey <>
Date:   2015-07-14T00:57:29Z

    Generalize Go func first line conversion.
    Prepare to make the conversion function which generates the first part
    of a Go method binding work with constructors and inert functions in
    addition to methods.

commit 5c86308e5ed25c74d1c0b5568f3acbae336e759a
Author: Marvin Humphrey <>
Date:   2015-07-14T02:03:41Z

    Auto-generate Go bindings for constructors.

commit e340a510dbcd00ea44aecc97101d9da88fa19805
Author: Marvin Humphrey <>
Date:   2015-07-14T19:01:13Z

    Make Err constructor public.

commit da43ffd0af8c862dfc4598f11bb9cd7de5e6b760
Author: Marvin Humphrey <>
Date:   2015-07-14T19:08:58Z

    Ensure that converted args outlive call.
    Eliminate a race condition by ensuring that the refcount decrement of a
    converted argument does not happen until after the call into C


> Autogenerate Go binding code
> ----------------------------
>                 Key: CLOWNFISH-32
>                 URL:
>             Project: Apache Lucy-Clownfish
>          Issue Type: Improvement
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
> Take the proof-of-concept hand-coded bindings from CLOWNFISH-28 and replace them with
autogenerated code whenever possible.

This message was sent by Atlassian JIRA

View raw message