lucy-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [lucy-issues] [jira] [Commented] (CLOWNFISH-58) Refine Hash API
Date Wed, 05 Aug 2015 22:29:04 GMT


ASF GitHub Bot commented on CLOWNFISH-58:

GitHub user rectang opened a pull request:

    CLOWNFISH-58 Hash Store nullable

    The signature for Hash's Store() method should accept `nullable` values.  The implementation
is already safe for use with NULL values, and we had already discussed that we needed `Has_Key`
to identify keys mapped to NULL. 

You can merge this pull request into a Git repository by running:

    $ git pull CLOWNFISH-58-store-nullable

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
commit 11fdf7fecb21102337fe713c35995b7898076143
Author: Marvin Humphrey <>
Date:   2015-08-05T01:43:40Z

    Hash_Store should accept nullable values.


> Refine Hash API
> ---------------
>                 Key: CLOWNFISH-58
>                 URL:
>             Project: Apache Lucy-Clownfish
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.5.0
> After reviewing the Hash API ([]), we decided to make
> some refinements:
> *   Remove Find_Key.
> *   Add Has_Key.
> *   Use `size_t` for capacity and other internal variables.
> *   Make Hash final.
> *   Expose the following methods as public: Clear, Store, Fetch, Delete, Keys,
>     Values, Get_Size, Equals
> *   Implement Clone() with shallow semantics.

This message was sent by Atlassian JIRA

View raw message