lucy-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [lucy-issues] [jira] [Commented] (CLOWNFISH-59) Refine Go bindings
Date Fri, 07 Aug 2015 03:47:45 GMT

    [ https://issues.apache.org/jira/browse/CLOWNFISH-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661262#comment-14661262
] 

ASF GitHub Bot commented on CLOWNFISH-59:
-----------------------------------------

GitHub user rectang opened a pull request:

    https://github.com/apache/lucy-clownfish/pull/32

    CLOWNFISH-59 Refine Go core types

    Refine the Go bindings and improve testing for Vector, Hash, Blob, Integer, Float, Boolean,
String, and Err.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rectang/lucy-clownfish CLOWNFISH-59-refine-go-core-types

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy-clownfish/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit db2fcaeef7deaf725bd72e9ee5f57c5359ee465b
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-04T18:55:17Z

    Don't convert return value of Clone().
    
    Have Clone return an Obj rather than an interface{}, and override the
    default binding which would convert some Clownfish types to Go types.

commit 6f711206b49c8d8cae119cb37b632d38d138e157
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-04T18:56:53Z

    Add tests for Vector Go bindings.

commit f6d4cfbda4b5ca306d0b6d3416cb680ce7b14601
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-04T21:56:00Z

    Change Go signature for Hash.Keys().
    
    Return a slice of strings instead of a slice of empty-interface.

commit ea6963b1cda260bbf4470d47d2f9c651b33dbd7b
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-04T22:09:35Z

    Add tests for Hash Go bindings.

commit 2f1681b10e95298faeca43db478fe3d7489e405a
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-05T02:06:47Z

    Better namespacing for Go String test funcs.

commit 85743e3dc6379c8069ea4af00aeb2d6acc0bd133
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-05T02:08:18Z

    Enable tests for String methods which take Obj.
    
    Now that Obj is mapped to Go empty-interface, we can test against Go
    strings.

commit a9ea5430b823bd626ce7b1f64f7d4f92addd9511
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-06T00:15:26Z

    Customize HashIterator Go ctor binding.

commit 0f60ed4b9902172e0f6b874fd24d6e303a4b4f00
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-06T00:16:49Z

    Add tests for HashIterator.

commit d34ae6fdbbbbe205f72ed63515cec94354e2e7eb
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-06T01:28:37Z

    Go binding for Blob_Get_Buf.

commit f7ff5b66a0916c70e611e87f753ec93106aa15c1
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-06T01:29:14Z

    Tests for Blob Go binding.

commit 18ab461b513ae6dc958fc2beee449be6b5b9e695
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-06T02:07:37Z

    Correct Go test package name.

commit 82023ccc6dc53778acc1c5e3c8114ffb864f9b41
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-06T02:09:28Z

    Test more Go method bindings for Err.

commit 6a43f1e570f9bb4abe3cae712c2351df1eec0fea
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-06T02:10:00Z

    Tests for Integer Go bindings.

commit a556c515f9d551e1f86d8788e14a197e132e7efc
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-06T02:40:25Z

    Tests for Float Go bindings.

commit 939b08ff6e76683d3826eefb5f357efa0ba00432
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-06T03:06:49Z

    Tests for Boolean Go bindings.

commit d947d8819be72c23b75213fe499aaf2371fc2c61
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-08-06T03:07:10Z

    Add missing case for converting Go `bool`.

----


> Refine Go bindings
> ------------------
>
>                 Key: CLOWNFISH-59
>                 URL: https://issues.apache.org/jira/browse/CLOWNFISH-59
>             Project: Apache Lucy-Clownfish
>          Issue Type: Improvement
>          Components: Go
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.5.0
>
>
> The autogenerated Go bindings are usually good, but in some cases should be overridden.
We also need tests for the Go bindings. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message