lucy-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [lucy-issues] [jira] [Commented] (CLOWNFISH-59) Refine Go bindings
Date Fri, 14 Aug 2015 22:42:45 GMT


ASF GitHub Bot commented on CLOWNFISH-59:

GitHub user rectang opened a pull request:

    CLOWNFISH-59 Tune Go conversion

    Fix some bugs and suboptimal behaviors in the Go conversion routines.

You can merge this pull request into a Git repository by running:

    $ git pull CLOWNFISH-59-tune-go-conv

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
commit e2152ee531a5b7cfbaad33b12a138e91851cf7ec
Author: Marvin Humphrey <>
Date:   2015-08-11T19:43:39Z

    Add Go binding for Obj_get_class.

commit 37aefb596c9967103fb1efb084e53da58fbd20f1
Author: Marvin Humphrey <>
Date:   2015-08-11T19:44:19Z

    Ensure proper Go wrapper for return vals.
    Access to the capabilities of a Clownfish object wrapped in a Go object
    depends on the Go wrapper being class-specific.  For instance, it does
    not suffice to wrap a `*C.cfish_Hash` inside a `clownfish.ObjIMP`,
    because you cannot invoke Hash operations on it.
    Therefore, use WRAPAny for return values, so that the most specific
    wrapper struct gets chosen.

commit 81ce545d140dc7bd0a1336a64c87f5c09ab961ed
Author: Marvin Humphrey <>
Date:   2015-08-13T02:59:01Z

    Add a missing incref.

commit 8172d40724759806bba44af34e1fd2883d89e8f8
Author: Marvin Humphrey <>
Date:   2015-08-13T02:59:47Z

    Add simple Go unwrapping function.

commit f3ed7660fb43abc67c3f7025b067115e9362517e
Author: Marvin Humphrey <>
Date:   2015-08-13T03:01:20Z

    Handle nil args in Go method wrappers.
    Parameters which have a default value of `NULL` map to a `nil` value in
    Go.  We can't call TOPTR() on them, so we need to use `UnwrapClownfish`.
    To prevent the generated invocation statement from getting ridiculously
    long, convert/unwrap *all* object types to temp variables.


> Refine Go bindings
> ------------------
>                 Key: CLOWNFISH-59
>                 URL:
>             Project: Apache Lucy-Clownfish
>          Issue Type: Improvement
>          Components: Go
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.5.0
> The autogenerated Go bindings are usually good, but in some cases should be overridden.
We also need tests for the Go bindings. 

This message was sent by Atlassian JIRA

View raw message