From issues-return-961-apmail-lucy-issues-archive=lucy.apache.org@lucy.apache.org Sat Aug 1 01:46:04 2015 Return-Path: X-Original-To: apmail-lucy-issues-archive@www.apache.org Delivered-To: apmail-lucy-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E90D9181EA for ; Sat, 1 Aug 2015 01:46:04 +0000 (UTC) Received: (qmail 80694 invoked by uid 500); 1 Aug 2015 01:46:04 -0000 Delivered-To: apmail-lucy-issues-archive@lucy.apache.org Received: (qmail 80665 invoked by uid 500); 1 Aug 2015 01:46:04 -0000 Mailing-List: contact issues-help@lucy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@lucy.apache.org Delivered-To: mailing list issues@lucy.apache.org Received: (qmail 80653 invoked by uid 99); 1 Aug 2015 01:46:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Aug 2015 01:46:04 +0000 Date: Sat, 1 Aug 2015 01:46:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@lucy.apache.org Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Subject: [lucy-issues] [jira] [Commented] (LUCY-281) Port host-specific Lucy code to Go/CGO [ https://issues.apache.org/jira/browse/LUCY-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650097#comment-14650097 ] ASF GitHub Bot commented on LUCY-281: ------------------------------------- GitHub user rectang opened a pull request: https://github.com/apache/lucy/pull/17 LUCY-281 Go/CGO port Port host-specific implementation code to Go/CGO instead of wrapping the C bindings. RegexTokenizer now uses the Go `regexp` package instead of requiring pcre. It references `regexp` objects from C using a variant on the Nick Wellnhofer's object registry code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rectang/lucy LUCY-281-cgo-port Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucy/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 ---- commit fed6ca76b6b8310c1db97bfbbed1b56af47e6194 Author: Marvin Humphrey Date: 2015-07-15T01:57:11Z Copy C host-specific code to Go. Copy the C binding code in anticipation of replacing it with Go-specific binding code. commit 633c4d30b74dbd69dbfc2c70c01c7638317c2d6a Author: Marvin Humphrey Date: 2015-07-19T23:47:23Z Remove RegexTokenizer_Set_Token_RE. It was used internally a long time ago and is now obsolete. commit dab9a88d5c654a2539e4a81db4d74f88cc976cf3 Author: Marvin Humphrey Date: 2015-07-17T03:32:45Z Make it possible to reference Go objects from C. This patch is a variant on sample code written by Nick Wellnhofer. commit 44fc440fdc419b655fb4c482afb63b9020138011 Author: Marvin Humphrey Date: 2015-07-19T19:57:13Z Port RegexTokenizer stubs to CGO. commit 8f634425b5390423d7c4013b28710e4ddc92bf0b Author: Marvin Humphrey Date: 2015-07-19T19:57:13Z Port Doc code to CGO. commit acd74d27985e635606c775a44d7c5c718583d76f Author: Marvin Humphrey Date: 2015-07-18T21:49:30Z Port Inverter and InverterEntry to CGO. commit 7749e595b2a6c32af57b904d1a00b066691ace37 Author: Marvin Humphrey Date: 2015-07-19T19:57:13Z Port DefDocReader code to CGO. commit 5f00a21335c3304c074223b2dba4567a62d9c97a Author: Marvin Humphrey Date: 2015-07-20T19:41:34Z Port RegexTokenizer to Go and CGO. Use Go's regular expression engine, the `regexp` package. Store Go `regexp` objects using the registry which allows them to be referenced by integer from C. ---- > Port host-specific Lucy code to Go/CGO > -------------------------------------- > > Key: LUCY-281 > URL: https://issues.apache.org/jira/browse/LUCY-281 > Project: Lucy > Issue Type: Improvement > Components: Go bindings > Reporter: Marvin Humphrey > Assignee: Marvin Humphrey > Fix For: 0.5.0 > > > A handful of components in Lucy require per-host implementation code: > * RegexTokenizer > * Doc > * DocReader > * Inverter > The Go bindings have been wrapping the C implementation code, but should use Go/CGO instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)