From issues-return-984-apmail-lucy-issues-archive=lucy.apache.org@lucy.apache.org Thu Sep 10 02:21:46 2015 Return-Path: X-Original-To: apmail-lucy-issues-archive@www.apache.org Delivered-To: apmail-lucy-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD4F617D7D for ; Thu, 10 Sep 2015 02:21:45 +0000 (UTC) Received: (qmail 73937 invoked by uid 500); 10 Sep 2015 02:21:45 -0000 Delivered-To: apmail-lucy-issues-archive@lucy.apache.org Received: (qmail 73910 invoked by uid 500); 10 Sep 2015 02:21:45 -0000 Mailing-List: contact issues-help@lucy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@lucy.apache.org Delivered-To: mailing list issues@lucy.apache.org Received: (qmail 73899 invoked by uid 99); 10 Sep 2015 02:21:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Sep 2015 02:21:45 +0000 Date: Thu, 10 Sep 2015 02:21:45 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@lucy.apache.org Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Subject: [lucy-issues] [jira] [Commented] (LUCY-282) Refine and test Go bindings [ https://issues.apache.org/jira/browse/LUCY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738020#comment-14738020 ] ASF GitHub Bot commented on LUCY-282: ------------------------------------- GitHub user rectang opened a pull request: https://github.com/apache/lucy/pull/19 LUCY-282 Refine Go bindings pt1 Refine Go bindings and add tests for many search classes, especially the Query classes. Also fix argument handling for OpenIndexer and OpenIndexSearcher. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rectang/lucy LUCY-282-refine-go-pt1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucy/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 ---- commit b69adb89aa9fc6a9c7d97c2729a9a0ceadc103be Author: Marvin Humphrey Date: 2015-08-11T20:07:02Z Support Folder as arg for IndexSearcher, Indexer. OpenIndexer and OpenIndexSearcher should accept either a Go `string` path or a Clownfish Folder as the `index` argument. commit 3d4a0b6cf0cc0131b10c452dba7bd91414780b3f Author: Marvin Humphrey Date: 2015-08-11T20:08:33Z Register WRAP functions in custom `init`. Since Lucy has its own custom `init` function, it needs to invoke `initWRAP` manually in order for `clownfish.WRAPAny` to know about Lucy-specific types. commit 71a17b05c10302769f335ff18103d875ac2fb255 Author: Marvin Humphrey Date: 2015-08-12T02:38:59Z Add test utility functions. Add Go versions of `createIndex`, `createSchema`. commit a28275ec8d7dd064f033afd81cfa43e3dd16d4ac Author: Marvin Humphrey Date: 2015-09-10T01:17:53Z Make NewANDQuery, NewORQuery take []Query. Have the Go bindings for the ANDQuery and ORQuery constructors take a slice of Query rather than a slice of empty interface. commit c0bdb9c44fd2e12b56f61e1b865df679147a992f Author: Marvin Humphrey Date: 2015-08-12T02:44:16Z Test Go bindings for Query classes. commit 0c44c9f505cd500d3f784b28c6c346a5f9c1396e Author: Marvin Humphrey Date: 2015-08-12T21:22:08Z Custom Go binding for `BitVec_To_Array`. Return a slice of bool. commit b76fe6aadf3c74071b444d0d3728bf83ed1e63fa Author: Marvin Humphrey Date: 2015-08-12T21:23:37Z Test Go bindings for BitVector. commit 456a82532432ac314f7c06a3d9f27e90aacf2384 Author: Marvin Humphrey Date: 2015-08-12T23:55:46Z Sanity check MockMatcher ctor args. commit 2b8b63236b2854b344cdba725f7ac6b60d844644 Author: Marvin Humphrey Date: 2015-08-12T23:58:06Z I32Array Go ctor binding. commit a7aa779141065a2964a70357d746522ae231d0aa Author: Marvin Humphrey Date: 2015-08-12T23:58:36Z MockMatcher Go ctor binding. commit db2c25da42f9b34aaabfd7c89b009229d04a1063 Author: Marvin Humphrey Date: 2015-08-13T00:43:39Z Test I32Array Go bindings. commit aa8e372efb1fd1bd21d8bde40eb7bd8088f1c22b Author: Marvin Humphrey Date: 2015-08-13T00:45:23Z Test BitVecMatcher Go bindings. commit aaf6abbe9909648b157dbaaabb1e84c71f47cb5a Author: Marvin Humphrey Date: 2015-08-13T03:05:34Z Make `similarity` arg optional. PolyMatchers already deal with NULL similarity correctly, so make it officially optional. commit 055407fccdd4739cb3e840e422ef43e3cff16bc3 Author: Marvin Humphrey Date: 2015-08-13T03:36:52Z Test Go bindings for Boolean matchers. commit 9cd103c7dfafa7153480789cb28618e4555abebd Author: Marvin Humphrey Date: 2015-09-10T01:55:21Z Make PolyMatcher ctor bindings take []Matcher. Make ANDMatcher, ORMatcher, and ORScorer constructors take a slice of Matcher rather than a slice of empty interface. ---- > Refine and test Go bindings > --------------------------- > > Key: LUCY-282 > URL: https://issues.apache.org/jira/browse/LUCY-282 > Project: Lucy > Issue Type: Improvement > Components: Go bindings > Reporter: Marvin Humphrey > Assignee: Marvin Humphrey > Fix For: 0.5.0 > > > Now that we have roughly useful automated Go bindings, work through them fine tuning for Go idiomatic usage and writing tests to ensure the Go bindings work as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)