lucy-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [lucy-issues] [jira] [Commented] (LUCY-282) Refine and test Go bindings
Date Sat, 21 Nov 2015 03:05:11 GMT

    [ https://issues.apache.org/jira/browse/LUCY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020201#comment-15020201
] 

ASF GitHub Bot commented on LUCY-282:
-------------------------------------

GitHub user rectang opened a pull request:

    https://github.com/apache/lucy/pull/29

    LUCY-282 Misc Go part 1

    Tune and test Go bindings for a variety of classes and methods.  Some were overlooked
during the first pass through the codebase creating custom Go bindings.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rectang/lucy LUCY-282-misc-go-pt1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #29
    
----
commit cc7219e69aaab7aa215ed6c39106d89a7df7ee83
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-10T01:42:08Z

    Tune and test PolyAnalyzer Go bindings.

commit e101acade8d9d2f1235b71e23db661e44359cf3d
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-10T04:16:04Z

    Tune and test Go bindings for Simple.

commit e35becd7dd804ceb103e19710f0aa85fd864e150
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-11T03:28:38Z

    Consolidate Searcher Go bindings.

commit d483dd076c36f3e8c29d80de5ad6e401e5531ca0
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-11T04:04:44Z

    More custom Go for Searcher.
    
    Hand-roll bindings for FetchDoc, fetchDocVec and topDocs to allow for
    returning a tuple including an `error`.

commit 3d636a19d41e9f049aaa444db097de5e31895e9a
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-13T03:11:48Z

    Add error retval for SortCache Go bindings.
    
    Some methods need to trap exceptions and return error objects.

commit 6d0a55f7387df4714386b7ffce9ba554c0c384f4
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-13T03:38:23Z

    Add error to Go binding for MakeMatcher.

commit dac0e2bd5d4f93f84842d393a59d3f84f215bf88
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-16T22:30:20Z

    Add error to Go binding for MakeCompiler.

commit dd4328b3a0c528e6d168c1c241bc07253c2e2c4b
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-16T23:35:54Z

    Catch errors in Go binding for DH_Next().
    
    Use the same approach we took with Hits_Next(): trap errors and capture
    them to a member variable, and expect the user to check that no errors
    occurred after iteration finishes.

commit d5063a519200d52c1abeec263bd008f176fa94bd
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-17T00:11:22Z

    Tune and test Go bindings for Stepper.

commit 91dd3894b16cc3f5140c2ac398d193a59f4b19a0
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-17T01:15:05Z

    Tune and test Go bindings for Doc.

commit 66120820174ffd6bc2459179fe642d094cc3ad57
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-17T02:16:28Z

    Test Go bindings for HitDoc.

commit 8208210b3f5877b2056fecd4fa19f4de94ccdd6e
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-17T02:33:40Z

    Trap errors in Go bindings for Matcher_Next.
    
    Use the same design pattern as Hits_Next: trap errors in a Go struct
    member and expect the user to check after iteration finishes.

----


> Refine and test Go bindings
> ---------------------------
>
>                 Key: LUCY-282
>                 URL: https://issues.apache.org/jira/browse/LUCY-282
>             Project: Lucy
>          Issue Type: Improvement
>          Components: Go bindings
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.5.0
>
>
> Now that we have roughly useful automated Go bindings, work through them fine tuning
for Go idiomatic usage and writing tests to ensure the Go bindings work as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message