lucy-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [lucy-issues] [jira] [Commented] (CLOWNFISH-63) Don't export private methods via Go
Date Sat, 07 Nov 2015 03:08:11 GMT

    [ https://issues.apache.org/jira/browse/CLOWNFISH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994968#comment-14994968
] 

ASF GitHub Bot commented on CLOWNFISH-63:
-----------------------------------------

GitHub user rectang opened a pull request:

    https://github.com/apache/lucy-clownfish/pull/42

    CLOWNFISH-63 Don't export private methods via Go v2

    Clownfish methods which are not marked as `public` should have the first letter of their
Go method name downcased so that they are not exported by the Go package.
    
    This pull requests differs from v1 in that it adds a missing include for ctype.h which
caused an Appveyor CI failure.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rectang/lucy-clownfish CLOWNFISH-63-Go-private-no-export-v2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy-clownfish/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #42
    
----
commit a0a3c6dbe59e7bdf64293c68032e1528345b7a63
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-04T02:02:16Z

    Make 3 TestSuite methods public.
    
    Make `Add_Batch`, `Run_Batch`, and `Run_All_Batches` public.

commit d442877690b4eaa03e6f2b2185e3b5fd2849c8bb
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-04T02:47:49Z

    Don't export private methods via Go.
    
    Downcase the first letter of the Go method name for methods not marked
    as `public`, so that they are not exported by the Go package.

commit 6f8c28faa333116ee46b99eff81b4c4de855e1aa
Author: Marvin Humphrey <marvin@rectangular.com>
Date:   2015-11-04T02:49:09Z

    Adapt to changes in Go names for private methods.
    
    Downcase the first letter of Go method names as required by recent API
    changes for Go bindings for private methods.  Such methods are only
    called from internal code and tests.

----


> Don't export private methods via Go
> -----------------------------------
>
>                 Key: CLOWNFISH-63
>                 URL: https://issues.apache.org/jira/browse/CLOWNFISH-63
>             Project: Apache Lucy-Clownfish
>          Issue Type: Bug
>          Components: Go
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.5.0
>
>
> Clownfish methods which are not marked as `public` should have the first letter of their
Go method name downcased so that they are not exported by the Go package.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message