mahout-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Lyubimov <dlie...@gmail.com>
Subject Re: About formatting patches
Date Fri, 15 Apr 2011 00:13:45 GMT
Hm. The one on Solr wiki doesn't open either. I tried two different browsers.

i'd be grateful if anybody could slurp the codestyle.xml for eclipse
for me from there.

Thanks
-Dmitriy

On Thu, Apr 14, 2011 at 4:48 PM, Dmitriy Lyubimov <dlieu.7@gmail.com> wrote:
> There's probably some error on this page :
> http://wiki.apache.org/lucene-java/HowToContribute?action=AttachFile&do=view&target=Eclipse-Lucene-Codestyle.xml
> when i click on the attachment link for eclipse style file
> http://wiki.apache.org/lucene-java/HowToContribute?action=AttachFile&do=view&target=Intellij-Lucene-Codestyle.xml
> i get error instead "You are not allowed to do AttachFile on this
> page. Login and try again.".
>
> I created an account there and logged in but i still can't download
> it, getting "You are not allowed to do AttachFile on this page."
>
> On Thu, Apr 14, 2011 at 4:37 PM, Dmitriy Lyubimov <dlieu.7@gmail.com> wrote:
>>>>
>>>> Eclipse autoformat function is not very useful really. In fact, IMO
>>>> code looks uglier after it than the version i created in the first
>>>> place.
>>>
>>> Ugly is not a particularly useful concept here compared to the idea of
>>> "standard".
>>
>> Yes. But I meant eclipse default autoformat is both subjectively
>> uglier while still no more standard.
>> Actually, Sean's cleanup had to cancel most of its effects on comment
>> and function calling.
>>
>> Eclipse does all that stuff you mentioned too, it just not doing all
>> of style checks on one hand  and not doing it "correctly"
>> (i.e. 100% maven checkstyle plugin style) by default.
>>
>> Although i need to check out that Lucene wiki to see if it helps to
>> address this in eclipse.
>>
>

Mime
View raw message