maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brett Porter (JIRA)" <j...@codehaus.org>
Subject [jira] Closed: (MIDEA-45) Problems with exclude logic
Date Sun, 02 Apr 2006 06:25:44 GMT
     [ http://jira.codehaus.org/browse/MIDEA-45?page=all ]
     
Brett Porter closed MIDEA-45:
-----------------------------

      Assign To: Brett Porter
     Resolution: Fixed
    Fix Version: 2.0

applied, thanks.

> Problems with exclude logic
> ---------------------------
>
>          Key: MIDEA-45
>          URL: http://jira.codehaus.org/browse/MIDEA-45
>      Project: Maven 2.x Idea Plugin
>         Type: Bug

>     Reporter: Patrick Lightbody
>     Assignee: Brett Porter
>      Fix For: 2.0
>  Attachments: excludeBugFix.patch
>
>
> The latest exclude logic has a couple problems:
> 1) an add() instead of an addAll() method causes some very funky IDEA behavior
> 2) a bug from my previous patch - the project's base dir was not used to build up the
resource dir, breaking reactor builds
> 3) the smart logic in getExcludedDirectories() is nice an all, but if the dirs don't
exist it does nothing. I provided a simpler implementation that may make most of that method
moot, but it doesn't hurt to keep it there either. By comparing the simple strings (after
having been sorted), you can achieve almost all the same optimizations.
> Patch supplied.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message