maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Binyan (JIRA)" <>
Subject [jira] Commented: (MNG-2546) Allow plugin executions in the "super-init" phase before reactor sorting of modules build order
Date Wed, 06 Sep 2006 15:49:02 GMT
    [ ] 
Binyan commented on MNG-2546:

This is really an implementation of the composite pattern IMO and we should flip the architecture.
 We need to have a default lifecycle the same as it exists today.  However the new default
lifecycle should have the pre and post reactor phases you wrote about in the email.  Then
the DefaultMaven class would invoke the LifecycleExecutor implementation, which would execute
the specified lifecycle (or new default if one wasn't specified) and the reactor should be
bound to a phase in the new default like any other plugin.  I think there should be a top
level element in the pom to indicate the lifecycle to use too.

> Allow plugin executions in the "super-init" phase before reactor sorting of modules build
> -----------------------------------------------------------------------------------------------
>                 Key: MNG-2546
>                 URL:
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Reactor and workspace
>    Affects Versions: 2.0.4
>            Reporter: Binyan
>         Attachments: MNG-2546-maven-core.patch
> As seen here,
 I also have the need to bind my maven-pde-plugin to a phase before the reactor sorting of
project build order happens.  My plugin is being developed to build eclipse plugins, features,
fragments, update sites and products.  Right now I can build plugins and features.  However
the order has to constantly be managed by the user taking information from the eclipse descriptors
and adding it to the pom file.  For plugin projects I can bind to a phase before the compile
phase and dynamically analyze the eclipse plugin descriptors and add the necessary dependencies/resources
to the MavenProject instance and all is well.  For feature projects, I also can dynamically
analyze the eclipse feature descriptor and add the necessary resources to the MavenProject
instance.  However, features depend on other plugins, fragments and features.  While I can
dynamicaly add the plugins, fragments and features to the MavenProject as dependencies they
are not taken into context as the reactor has already computed the sorting order.
> What would be perfect is if there was a "super-init" phase that plugins could bind to
and be executed in before the normal declared lifecycle happened.  Therefore no matter what
the lifecycle was, the "super-init" phase would be available.  Then plugins could do things
like augmenting the super-pom with build #'s/identifiers, dependencies, dynamic projects,
etc all before maven gets going.  That would solve the problem myself and others have as well
as be 100% backwards compatible.  This super-init phase (please pick a better name) would
e available to reactor and non-reactor builds.  A more specific fix would be to allow plugins
to ask the reactor to reevaluate the build order.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


View raw message