maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlos Sanchez (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MSUREFIREREP-33) Detail display doesn't work if there are tests with the same name
Date Tue, 03 Oct 2006 11:49:27 GMT
    [ http://jira.codehaus.org/browse/MSUREFIREREP-33?page=comments#action_76427 ] 
            
Carlos Sanchez commented on MSUREFIREREP-33:
--------------------------------------------

This patch should make it work but it does not.

{code}
Index: src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
===================================================================
— src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java (revision
452343)
+++ src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java (working
copy)
@@ -407,10 +407,10 @@
 
                             sink.rawText( "  <div class=\"detailToggle\" style=\"display:inline\">"
);
 
-                            sink.link( "javascript:toggleDisplay('" + testCase.getName()
+ "');" );
+                            sink.link( "javascript:toggleDisplay('" + testCase.getFullName()
+ "');" );
 
-                            sink.rawText( "<span style=\"display: inline;\" " + "id=\""
+ testCase.getName() +
-                                "off\">+</span><span id=\"" + testCase.getName()
+ "on\" " +
+                            sink.rawText( "<span style=\"display: inline;\" " + "id=\""
+ testCase.getFullName() +
+                                "off\">+</span><span id=\"" + testCase.getFullName()
+ "on\" " +
                                 "style=\"display: none;\">-</span> " );
                             sink.text( "[ Detail ]" );
                             sink.link_();
{code}


> Detail display doesn't work if there are tests with the same name
> -----------------------------------------------------------------
>
>                 Key: MSUREFIREREP-33
>                 URL: http://jira.codehaus.org/browse/MSUREFIREREP-33
>             Project: Maven 2.x Surefire report Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Carlos Sanchez
>             Fix For: 2.1
>
>
> toggleDisplay uses only the name of the test method for identifying the tests, it should
use the full class name+method name

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message