maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arnaud Heritier (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MPPDF-57) Unable to remove cover type and version
Date Thu, 26 Oct 2006 22:58:04 GMT
    [ http://jira.codehaus.org/browse/MPPDF-57?page=comments#action_78556 ] 
            
Arnaud Heritier commented on MPPDF-57:
--------------------------------------

Lukas, I reproduced (and fixed) it with wendy's testcase
In fact it's logical because there's no test arround the cover type attribute.
If maven.pdf.cover.type is empty or null, the generated command line will be :
.... -PARAM coverType -PARAM coverVersion ...
Thus coverType=-PARAM and coverVersion isn't used.
I just added the same test like for the version
      <j:set var="_coverType" value="${maven.pdf.cover.type}"/>
      <j:if test="${not empty(_coverType)}">
        <arg value="-PARAM"/>
        <arg value="coverType"/>
        <arg value="${_coverType}"/>
      </j:if>
And I removed the default value in project2fo.xslt
I'm not sure if we don't have to this test for each PARAM to be sure to not reproduce it later..

> Unable to remove cover type and version
> ---------------------------------------
>
>                 Key: MPPDF-57
>                 URL: http://jira.codehaus.org/browse/MPPDF-57
>             Project: maven-pdf-plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>         Environment: Maven 1.1-RC1-SNAPSHOT
>            Reporter: Wendy Smoak
>         Assigned To: Lukas Theussl
>             Fix For: 2.5.1
>
>         Attachments: pdf-test.tar.gz, svn-intro.pdf
>
>
> I'm trying to remove the 'cover type' and 'cover version' (set them to blank/nothing.)
 If I put the following in project.properties:
>    maven.pdf.cover.type=
>    maven.pdf.cover.version=
> I get the text '-PARAM' for the cover type, and 'v1.0' for the cover version.
> If I try it again with '.' for both of those properties, cover type works (just prints
a dot) but cover version prints 'v..'.  
> This seems to call for something like a 'maven.pdf.cover.version.prefix' property (that
can be set to blank.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message