maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Brunner (JIRA)" <j...@codehaus.org>
Subject [jira] Created: (MECLIPSE-237) unsafe EclipseSourceDir.equals() method
Date Mon, 12 Mar 2007 15:54:34 GMT
unsafe EclipseSourceDir.equals() method
---------------------------------------

                 Key: MECLIPSE-237
                 URL: http://jira.codehaus.org/browse/MECLIPSE-237
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
    Affects Versions: 2.4
            Reporter: Klaus Brunner
            Priority: Trivial


EclipseSourceDir.equals(Object o) does not check the passed object for null or incompatible
class, which may cause NPEs and ClassCastExceptions.

Fix suggestion:

    public boolean equals( Object obj )
    {
        return (obj != null) && (obj instanceof EclipseSourceDir) && this.path.equals(
( (EclipseSourceDir) obj ).path );
    }


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message