maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Wiedmann (JIRA)" <j...@codehaus.org>
Subject [jira] Created: (MSOURCES-14) Replace maven-verifier with maven-plugin-testing-harness
Date Mon, 26 Mar 2007 09:36:35 GMT
Replace maven-verifier with maven-plugin-testing-harness
--------------------------------------------------------

                 Key: MSOURCES-14
                 URL: http://jira.codehaus.org/browse/MSOURCES-14
             Project: Maven 2.x Sources Plugin
          Issue Type: Bug
    Affects Versions: 2.0.3
            Reporter: Jochen Wiedmann
         Attachments: maven-source-plugin-harness.patch

The test suite of the maven-sources-plugin is currently based on the maven-verifier. This
has the undesirable consequence, that the test uses the *installed* version of the maven-sources-plugin,
as opposed to the local version.

The attached patch replaces the maven-verifier with the maven-plugin-testing-harness, which
doesn't suffer from the same problem. Additionally, the speed of the test suite is drastically
improved.

For reviewers: When considering the patches quality, keep in mind that the actual Mojo classes
and the concrete test classes are almost unchanged. (For the latter, there is the required
addition of a protected method getGoal().)

For reviewers: Note the following comment in AbstractSourcePluginTestCase:

         * I don't know, why revision 518116 of this class had the parameters
         * "properties" and "expectNoErrors". The following checks demonstrate,
         * that the parameters aren't actually used and may safely be removed.
         * This should be done by the patch reviewer.

I recommend that the reviewer follows my suggestion by applying a refactoring method after
applying my patch.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message