maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nigel Magnay (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MNG-2301) Maven Archiver deleteing already existing pom.properties file.
Date Mon, 19 Mar 2007 18:13:34 GMT

    [ http://jira.codehaus.org/browse/MNG-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_90505
] 

Nigel Magnay commented on MNG-2301:
-----------------------------------

> IMO, this could be a vector for introducing false data which may eventually be depended
upon (even unintentionally)...I'd tend to say that this file should always be generated.

This seems right to me - it sounds like the fix in MNG-2854 also helps with this by moving
the pom.properties artifact into a target subdirectory, which seems right. That way even if
it doesn't get deleted, you know that it's always generated, and the risk that you're taking.

> Maven Archiver deleteing already existing pom.properties file.
> --------------------------------------------------------------
>
>                 Key: MNG-2301
>                 URL: http://jira.codehaus.org/browse/MNG-2301
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Sharmarke Aden
>             Fix For: 2.0.x
>
>         Attachments: maven-archiver_pomDelete.patch
>
>
> My project has it's own pom.properties file and it seems that maven archiver is deleting
it right after packaging the application. Any particular reason why it's doing this? It seems
to me the archiver shouldn't be deleting the file if it already exists. It should delete the
file if it doesn't exists otherwise it should add the necessary information (version, groupId,
etc) to the file and leave it be. I have attached a patch that fixes the issue. 
> Also note that this patch adds the "builtOn" property to the pom.properties which is
satisfy the following enhancement request: http://jira.codehaus.org/browse/MNG-1830 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message