maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "KlaasJan Elzinga (JIRA)" <j...@codehaus.org>
Subject [jira] Updated: (MWAR-96) WebResource not filtered with system properties.
Date Tue, 03 Apr 2007 08:14:06 GMT

     [ http://jira.codehaus.org/browse/MWAR-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

KlaasJan Elzinga updated MWAR-96:
---------------------------------

    Attachment: patch-junit-test.txt

Patch for junit test (patch-junit-test.txt). It shows that the java.version is not filtered.


I investigated a little further and found the following:
CompositeMap uses a dominant map and a recessive map. The dominant map is the pom (basically).
It uses reflection to locate for example java.version. This value is found in the project
since the ReflectionExtractor is stripping any root comments (java. in this case).  So for
java.version the pom.version value is found.

I tried calling ReflectionValueExtractor with trimToken = false, but then no dominant values
were found.

> WebResource not filtered with system properties.
> ------------------------------------------------
>
>                 Key: MWAR-96
>                 URL: http://jira.codehaus.org/browse/MWAR-96
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0.2
>         Environment: java 5.0, Windows XP
>            Reporter: KlaasJan Elzinga
>         Attachments: patch-junit-test.txt
>
>
> When filtering a resource:
>           <webResources>        
>             <resource>
>               <directory>${basedir}/src/main/resources/</directory>
>               <filtering>true</filtering>
>               <includes>
>                  <include>index.jsp</include>
>               </includes>                  
>             </resource>
>           </webResources>
> The index.jsp contains:
> 	<tr><td>java version</td><td>${java.version}</td></tr>
> 	<tr><td>Project</td><td>${pom.name}</td></tr>
> 	<tr><td>Version</td><td>${pom.version}</td></tr>
> After mvn clean install the filtered index.jsp looks like:
> 	<tr><td>java version</td><td>1.0.0.SNAPSHOT</td></tr>
> 	<tr><td>Project</td><td>FrieslandBank TMS TNS WebApp</td></tr>
> 	<tr><td>Version</td><td>1.0.0.SNAPSHOT</td></tr>
> The value java.version is filtered to the version of the pom and not  the system property.
The same goes for os.name which is translated to pom.name.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message