maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bentmann (JIRA)" <j...@codehaus.org>
Subject [jira] Issue Comment Edited: (MRESOURCES-52) Change type of plugin parameter "outputDirectory" to java.io.File
Date Mon, 14 Jan 2008 22:57:57 GMT

    [ http://jira.codehaus.org/browse/MRESOURCES-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_119887
] 

bentmann edited comment on MRESOURCES-52 at 1/14/08 4:57 PM:
----------------------------------------------------------------------

There will not be any noticable changes for the end-user regarding plugin configuration. For
example, I tested the patch with the same test POM, no changes were required.

It's all strings in the XML configuration, whether this is pushed into a File or a String
is transparent to the user. That's similar to plugin parameters of type Array or Collection
which - from the perspective of the POM - cannot be distinguished (see also [Guide to Java
Plugin Development, Parameters|http://maven.apache.org/guides/plugin/guide-java-plugin-development.html]).

      was (Author: bentmann):
    There will not be any noticable changes for the end-user regarding plugin configuration.
For example, I tested the patch with the same test POM, no changes were required.

It's all strings in the XML configuration, whether this is pushed into a File or a String
is transparent to the user. That's similar to plugin parameters of type Array or Collection
which - from the perspective of the POM - cannot be distinguished.
  
> Change type of plugin parameter "outputDirectory" to java.io.File
> -----------------------------------------------------------------
>
>                 Key: MRESOURCES-52
>                 URL: http://jira.codehaus.org/browse/MRESOURCES-52
>             Project: Maven 2.x Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Benjamin Bentmann
>            Assignee: Milos Kleint
>             Fix For: 2.3
>
>         Attachments: output-directory.patch, resources.zip
>
>
> As described by MNG-3273, using java.lang.String for path parameters is discouraged as
it usually leads to relative paths being resolved against the current working directory instead
of the project's base directory. This bug manifest itselfs when a user explicitly configures
the maven-resources-plugin with a relative output directory and then runs the build from a
different working directory (for example, the base directory of an aggregator parent).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message