maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arnaud Heritier (JIRA)" <j...@codehaus.org>
Subject [jira] Closed: (MECLIPSE-294) Sort items in the generated .classpath
Date Thu, 31 Jan 2008 00:08:57 GMT

     [ http://jira.codehaus.org/browse/MECLIPSE-294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Arnaud Heritier closed MECLIPSE-294.
------------------------------------

    Resolution: Fixed

Fixed. All test cases pass.

> Sort items in the generated .classpath
> --------------------------------------
>
>                 Key: MECLIPSE-294
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-294
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.3
>            Reporter: Max Bowsher
>            Assignee: Arnaud Heritier
>             Fix For: 2.5
>
>         Attachments: eclipse-sort.patch
>
>
> Currently, the ordering of items on the generated .classpath is controlled by the JVM's
HashSet ordering.
> One effect of this is that the project-07 and project-33 tests are currently commented
out, because it's impossible to write an expected/.classpath file that works everywhere.
> More generally, it's bad that the classpath ordering can vary between platforms and JVM
orderings.
> Therefore, I think it would be a good idea to sort the classpath. This would be done
by invoking Collections.sort in AbstractIdeSupportMojo.doDependencyResolution. IdeDependency
already implements Comparable, on the basis of groupId+artifactId+type. Classifier should
be added to the properties considered in compareTo.
> Patch attached as described above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message