From issues-return-35010-apmail-maven-issues-archive=maven.apache.org@maven.apache.org Tue Jan 15 11:06:33 2008 Return-Path: Delivered-To: apmail-maven-issues-archive@locus.apache.org Received: (qmail 48668 invoked from network); 15 Jan 2008 11:06:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Jan 2008 11:06:33 -0000 Received: (qmail 33183 invoked by uid 500); 15 Jan 2008 11:06:22 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 33142 invoked by uid 500); 15 Jan 2008 11:06:22 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 33131 invoked by uid 99); 15 Jan 2008 11:06:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jan 2008 03:06:22 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com) (63.246.2.115) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jan 2008 11:06:08 +0000 Received: from codehaus01.managed.contegix.com (localhost.localdomain [127.0.0.1]) by codehaus01.managed.contegix.com (Postfix) with ESMTP id AC9261660015 for ; Tue, 15 Jan 2008 05:05:58 -0600 (CST) Message-ID: <10964522.1200395158694.JavaMail.haus-jira@codehaus01.managed.contegix.com> Date: Tue, 15 Jan 2008 05:05:58 -0600 (CST) From: "Jelte van der Hoek (JIRA)" To: issues@maven.apache.org Subject: [jira] Commented: (MASSEMBLY-257) OutOfMemoryError when assembling large binary file In-Reply-To: <3715179.1197537597636.JavaMail.haus-jira@codehaus01.managed.contegix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://jira.codehaus.org/browse/MASSEMBLY-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_119938 ] Jelte van der Hoek commented on MASSEMBLY-257: ---------------------------------------------- For what it's worth, here's a new patch based on current trunk: {noformat} Index: maven-assembly-plugin/src/main/java/org/apache/maven/plugin/assembly/format/FileFormatter.java =================================================================== --- maven-assembly-plugin/src/main/java/org/apache/maven/plugin/assembly/format/FileFormatter.java (revision 612068) +++ maven-assembly-plugin/src/main/java/org/apache/maven/plugin/assembly/format/FileFormatter.java (working copy) @@ -79,6 +79,12 @@ { File result = source; + // MASSEMBLY-257: bail out if there is nothing to change. + if( !filter && AssemblyFileUtils.getLineEndingCharacters( lineEnding )==null ) + { + return result; + } + AssemblyFileUtils.verifyTempDirectoryAvailability( tempRoot, logger ); {format} > OutOfMemoryError when assembling large binary file > -------------------------------------------------- > > Key: MASSEMBLY-257 > URL: http://jira.codehaus.org/browse/MASSEMBLY-257 > Project: Maven 2.x Assembly Plugin > Issue Type: Bug > Affects Versions: 2.2-beta-1 > Reporter: Jelte van der Hoek > Attachments: fileitem-oome.patch > > > The assembly phase reads all files into a single String, irrespective of whether they need filtering or not. > This makes it unable to handle large binary files in an assembly. > The quick fix for this is to not read the file at all if there is no 'lineEnding' nor 'filtered' option set. > (The long fix would be to not read the file that way) > Patch against 2.2-beta-1 attached (most of the patch changes . -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira