maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Casey (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MASSEMBLY-256) Regression: pom properties are no longer expanded in descriptor.
Date Mon, 25 Feb 2008 15:37:28 GMT

    [ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_124976
] 

John Casey commented on MASSEMBLY-256:
--------------------------------------

Are you saying that the code changes I made aren't affecting this issue? The problem is, we
have two-stage "interpolation" if you like in the assembly descriptor. Stage one uses only
information from the project being built, and happens up front before the assembly is put
together. In this stage, the output locations are not subject to interpolation, since they
may have properties referring to the artifacts/files they are dealing with. Stage two happens
at the point where a dependencySet, fileSet, etc. is actually included in the assembly. In
this case, artifact information is combined with information from the current project, to
enable both things like ${project.build.finalName} and ${project.properties.foo}, along with
${artifact.artifactId}.

The ${project.properties.foo} is actually the part that changed very recently, allowing their
inclusion in these output locations. I've deployed a proposed release for the assembly plugin
for people to test, though I can't be certain that I deployed a snapshot of the assembly plugin
with this code in place. Please see:

http://article.gmane.org/gmane.comp.jakarta.turbine.maven.devel/84081

for links and instructions on testing.

> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
>                 Key: MASSEMBLY-256
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-256
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-2
>         Environment: maven 2.0.8
> windows xp sp2
>            Reporter: Mark Reynolds
>            Assignee: John Casey
>             Fix For: 2.2-beta-2
>
>         Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
>     <project>
>         ...
>         <properties>
>             <fileLocation>file/path</fileLocation>
>         </properties>
>     </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
>     ...
>     <fileSets>
>         <fileSet>
>             <directory>src/main/files</directory>
>             <outputDirectory>${fileLocation}</outputDirectory>
>         </fileSet>
>     </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is
expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message