maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Fabulich (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (SUREFIRE-451) ManifestJarWriter should use java.util.jar.Manifest
Date Tue, 05 Feb 2008 21:48:30 GMT

    [ http://jira.codehaus.org/browse/SUREFIRE-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122489
] 

Dan Fabulich commented on SUREFIRE-451:
---------------------------------------

Notably, I find that the difference between the two is that java.util.jar.Manifest creates
a manifest with TWO final newlines; ManifestJarWriter as-is currently creates a manifest with
just ONE final newline.

> ManifestJarWriter should use java.util.jar.Manifest
> ---------------------------------------------------
>
>                 Key: SUREFIRE-451
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-451
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: process forking
>            Reporter: Dan Fabulich
>
> ManifestJarWriter manages writing the manifest by hand, including wrapping lines, etc.
etc.  This code was copied from plexus-archiver when we stopped depending on plexus-archiver.
> But AFAIK there's no reason to do that by hand; java.util.jar.Manifest can take care
of all of that for us.  Still, it's creepy that they did all of that work, so maybe there
was a good reason for it...?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message