maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Gier (JIRA)" <j...@codehaus.org>
Subject [jira] Updated: (MRESOURCES-39) Filtering fails for command line properties
Date Fri, 22 Feb 2008 21:00:29 GMT

     [ http://jira.codehaus.org/browse/MRESOURCES-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paul Gier updated MRESOURCES-39:
--------------------------------

    Attachment: maven-resources-plugin-prop-filtering-r630241.patch

The problem seems to be that the resources plugin first adds all the system properties to
it's properties object, then adds properties from project.getProperties().  So the project
properties override the system properties.

The patch reverses this order, and changes one test case to reflect this change.  The only
problem I see is if you wanted to override some default system property (for example "user.home")
in your pom, you wouldn't be able to do this anymore.  I didn't find any easy way to get just
the command line props from within the plugin, but if this was possible it would probably
be a better solution.

> Filtering fails for command line properties
> -------------------------------------------
>
>                 Key: MRESOURCES-39
>                 URL: http://jira.codehaus.org/browse/MRESOURCES-39
>             Project: Maven 2.x Resources Plugin
>          Issue Type: Bug
>         Environment: maven-2.0.4 and maven-2.0.5
> Mac OS X
>            Reporter: Matt Brozowski
>            Priority: Critical
>         Attachments: filtering-bug.tar, maven-resources-plugin-prop-filtering-r630241.patch
>
>
> When passing a property on the command line to maven using -D it does not properly override
values passed to filters.
> I have attached a sample project that defines a property in the pom.xml called 'filtered'
  This property is used as a filter in the filtered.properties file in src/main/filtered/filtered.properties.
 I have also included a test that gets passed the filtered property as a System property via
the surefire plugin.  It then loaded the filtered.properties file and tests to ensure the
filters match.
> The tests pass when run as
> mvn test
> BUT if I run as 
> mvn -Dfiltered=from-cmd-line teset
> They fail.
> I have also included the antrun plugin print its perspective on the value of the property.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message