maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Heß (JIRA) <j...@codehaus.org>
Subject [jira] Commented: (MASSEMBLY-298) Includes/Excludes within <unpackOptions> are ignored
Date Mon, 26 May 2008 12:48:21 GMT

    [ http://jira.codehaus.org/browse/MASSEMBLY-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=136163#action_136163
] 

Michael Heß commented on MASSEMBLY-298:
---------------------------------------

Was this problem not supposed to be fixed since 2.2-beta2? 

See http://jira.codehaus.org/browse/MASSEMBLY-195

Maybe we should just reopen 195?

> Includes/Excludes within <unpackOptions> are ignored
> ----------------------------------------------------
>
>                 Key: MASSEMBLY-298
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-298
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-2
>         Environment: Maven 2.0.8, Intel Mac 10.5, JDK 5.0
>            Reporter: Nathaniel Harward
>         Attachments: module-set-assembly-phase.patch
>
>
> I have the following snippet in my assembly descriptor which does not work:
> --snip--
> <moduleSet>
>                         <includes>
>                                 <include>my:module</include>
>                         </includes>
>                         <binaries>
>                                 <unpack>true</unpack>
>                                 <unpackOptions>
>                                         <excludes>
>                                                 <exclude>META-INF/**</exclude>
>                                                 <exclude>**/.do_not_remove</exclude>
>                                         </excludes>
>                                 </unpackOptions>
>                                 <outputFileNameMapping/>
>                                 <outputDirectory>/</outputDirectory>
>                                 <fileMode>644</fileMode>
>                                 <directoryMode>755</directoryMode>
>                         </binaries>
>                 </moduleSet>
> --snip--
> Debug output shows:
> --snip--
>         [DEBUG] includes:
>         **/*
>         [DEBUG] excludes:
>         none
> --snip--
> I believe the problem is at line 271/272 of ModuleSetAssemblyPhase (in the 2.2-beta-2
revision, anyway) -- it calls "task.setUnpack( binaries.isUnpack() );" but does not set the
unpack options (if present), hence they are ignored :(
> Patch is attached, and works just fine in my case above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message