maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Janes (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (SCM-414) Patch Submisson Fix Maven Perforce SCM Plugin so that it will work with Continuum
Date Tue, 30 Sep 2008 18:54:45 GMT

    [ http://jira.codehaus.org/browse/SCM-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=149419#action_149419
] 

Peter Janes commented on SCM-414:
---------------------------------

Apologies, I was reading the patch in isolation from the report.  The DataOutputStream changes
do appear to be necessary.

I proposed an alternative solution which supports P4 ticket-based login (and probably the
P4PASSWD variable as well, although that's untested) in SCM-415.

> Patch Submisson Fix Maven Perforce SCM Plugin so that it will work with Continuum
> ---------------------------------------------------------------------------------
>
>                 Key: SCM-414
>                 URL: http://jira.codehaus.org/browse/SCM-414
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-perforce
>    Affects Versions: 1.1
>         Environment: Tested on linux should work on any platform.
>            Reporter: David Trott
>         Attachments: perforce.diff, scm-414.patch
>
>
> There are a couple of issues with picking up the perforce password.
> - Added code to pick it up from the standard environment (P4PASSWD) if not set elsewhere.
> - Changed the DataOutputStream to a OutputStreamWriter as the DataOutputStream throws
in extra unicode characters
> The "file(s) up-to-date" message has a different case F on different platforms.
> Omitted it the F from the string compare.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message