maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bentmann (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MSHARED-55) NLP IF no fileset directory specified.
Date Wed, 03 Sep 2008 19:08:51 GMT

    [ http://jira.codehaus.org/browse/MSHARED-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146872#action_146872
] 

Benjamin Bentmann commented on MSHARED-55:
------------------------------------------

Petar, I am not sure whether your patch really solves MASSEMBLY-342. You are simply avoiding
the NPE in the FileSetManager but as far as I understand, the NPE is adequate: A required
parameter is missing and I wouldn't consider a FileSet without base directory a valid object.
The Assembly Plugin is responsible to properly configure the FileSet before passing it down
to the FileSetManager, so that needs fixing. In particular, consider the POM snippet given
over at the MASSEMBLY-342
{code:xml}
<fileSet>
  <filtered>true</filtered>
  <includes>
    <include>INSTALL*</include>
    <include>README*</include>
    <include>LICENSE*</include>
    <include>NOTICE*</include>
  </includes>
</fileSet>
{code}
which suggests that the user wants the FileSet to use the project's base directory. This is
a completely different semantics than just returning an empty result list.

To summarize: I think this issue itself should be closed as "Won't fix". To real work is over
in the Assembly Plugin.

> NLP IF no fileset directory specified.
> --------------------------------------
>
>                 Key: MSHARED-55
>                 URL: http://jira.codehaus.org/browse/MSHARED-55
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: file-management
>    Affects Versions: file-management 1.2
>         Environment: all
>            Reporter: Petar Tahchiev
>         Attachments: massembly-342.txt, mshared55-ver.1.txt, mshared55-ver1-testcase.txt
>
>
> Hi guys I have created a patch for the MASSEMBLY-342 that should be applied to FileSetManager.
This patch fixes a but that can arise if you make assemblies and in your assembly-descriptor
you have filesets that don't specify directory.
> For further info please look here:
> http://jira.codehaus.org/browse/MASSEMBLY-342

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message