maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@codehaus.org>
Subject [jira] Issue Comment Edited: (MASSEMBLY-309) outputFileNameMapping fails and includes parent's name
Date Fri, 19 Sep 2008 12:09:50 GMT

    [ http://jira.codehaus.org/browse/MASSEMBLY-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=148499#action_148499
] 

sgfan edited comment on MASSEMBLY-309 at 9/19/08 7:09 AM:
-------------------------------------------------------------------

JD,

I was able to reproduce the issue on your example with simple change which resembles my code:

{noformat}
--- E:/Downloads/massembly-309/src/main/assembly/bin.xml	Fri Sep 19 13:53:05 2008
+++ E:/massembly-309/src/main/assembly/bin.xml	Fri Sep 19 13:50:47 2008
@@ -1,13 +1,13 @@
 <assembly>
   <id>bin</id>
   <formats>
-    <format>dir</format>
+    <format>zip</format>
   </formats>
   <moduleSets>
     <moduleSet>
       <binaries>
         <includeDependencies>false</includeDependencies>
-        <outputFileNameMapping>module-${module.artifactId}-${module.version}.${module.extension}</outputFileNameMapping>
+        <outputFileNameMapping>module-${artifactId}-${version}.${extension}</outputFileNameMapping>
         <unpack>false</unpack>
       </binaries>
     </moduleSet>
@@ -15,7 +15,7 @@
       <binaries>
         <attachmentClassifier>javadoc</attachmentClassifier>
         <includeDependencies>false</includeDependencies>
-        <outputFileNameMapping>module-${module.artifactId}-${module.version}-${module.classifier}.${module.extension}</outputFileNameMapping>
+        <outputFileNameMapping>module-${artifactId}-${version}-${classifier}.${extension}</outputFileNameMapping>
         <unpack>false</unpack>
       </binaries>
     </moduleSet>
{noformat}

After that I added "module." to my bin.xml and it resolved the issue somewhat. This simply
means that omitting the "module." does cause an interpolation error. I omitted the "module."
because the documenation for the asssembly plugin told me so.
The prop name addition resolved only the jar naming issue. The site directory is still broken!
You may checkout my [2.4 tag|http://svn.fckeditor.net/FCKeditor.Java/tags/2.4/] and change
the assembly plugin version and the properties and see the broken jars and the messed up site
directory in the bin zip.
Additionally I added 2 images depicting the site dir issue.

      was (Author: sgfan):
    JD,

I was able to reproduce the issue on your example with simple change which resembles my code:

{noformat}
--- E:/Downloads/massembly-309/src/main/assembly/bin.xml	Fri Sep 19 13:53:05 2008
+++ E:/massembly-309/src/main/assembly/bin.xml	Fri Sep 19 13:50:47 2008
@@ -1,13 +1,13 @@
 <assembly>
   <id>bin</id>
   <formats>
-    <format>dir</format>
+    <format>zip</format>
   </formats>
   <moduleSets>
     <moduleSet>
       <binaries>
         <includeDependencies>false</includeDependencies>
-        <outputFileNameMapping>module-${module.artifactId}-${module.version}.${module.extension}</outputFileNameMapping>
+        <outputFileNameMapping>module-${artifactId}-${version}.${extension}</outputFileNameMapping>
         <unpack>false</unpack>
       </binaries>
     </moduleSet>
@@ -15,7 +15,7 @@
       <binaries>
         <attachmentClassifier>javadoc</attachmentClassifier>
         <includeDependencies>false</includeDependencies>
-        <outputFileNameMapping>module-${module.artifactId}-${module.version}-${module.classifier}.${module.extension}</outputFileNameMapping>
+        <outputFileNameMapping>module-${artifactId}-${version}-${classifier}.${extension}</outputFileNameMapping>
         <unpack>false</unpack>
       </binaries>
     </moduleSet>
{noformat}

After that I added "module." to my bin.xml and it resolved the issue somewhat. This simply
means that omitting the "module." does cause an interpolation error. I omitted the "module."
because the documenation for the asssembly plugin told me so.
The prop name addition resolved only the jar naming issue. The site directory is still broken!
You may checkout my [2.4|http://svn.fckeditor.net/FCKeditor.Java/tags/2.4/] and change the
assembly plugin version and the properties and see the broken jars and the messed up site
directory in the bin zip.
Additionally I added 2 images depicting the site dir issue.
  
> outputFileNameMapping fails and includes parent's name
> ------------------------------------------------------
>
>                 Key: MASSEMBLY-309
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-309
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-2
>         Environment: Maven 2.0.9, JDK6, WinXP SP2 AND debian 4.0, Maven 2.0.8, JDK6 AND
Maven Embedder m2eclipse 0.9.1
>            Reporter: Michael Osipov
>            Assignee: John Casey
>            Priority: Critical
>             Fix For: 2.2-beta-3
>
>         Attachments: broken_example.png, expected_example.png, massembly-309.zip
>
>
> I have created a bin assembly descriptor containing:
> {code}
> <moduleSets>
> 		<moduleSet>
> 			<includes>
> 				<include>*:jar</include>
> 			</includes>
> 			<binaries>
> 				<includeDependencies>false</includeDependencies>
> 				<outputFileNameMapping>
> 					fckeditor-${module.artifactId}-${module.version}.${module.extension}
> 				</outputFileNameMapping>
> 				<unpack>false</unpack>
> 			</binaries>
> 		</moduleSet>
> 		<moduleSet>
> 			<includes>
> 				<include>*:jar</include>
> 			</includes>
> 			<binaries>
> 				<attachmentClassifier>javadoc</attachmentClassifier>
> 				<includeDependencies>false</includeDependencies>
> 				<outputFileNameMapping>
> 					fckeditor-${module.artifactId}-${module.version}-${module.classifier}.${module.extension}
> 				</outputFileNameMapping>
> 				<unpack>false</unpack>
> 			</binaries>
> 		</moduleSet>
> 	</moduleSets>
> {code}
> The expected zip distro should look like the expected attachment but sometimes (80 %)
the outcome is the broken example.
> It seems like it does not resolves the module but the my parent. Browser my source [here|http://dev.fckeditor.net/browser/FCKeditor.Java/branches/2.4]
if you like.
> Interesting to say if the bin distro is fine, maven reports (note the parent warning):
> {code}
> [INFO] [assembly:assembly]
> [INFO] Reading assembly descriptor: src/main/assembly/src.xml
> [INFO] Reading assembly descriptor: src/main/assembly/bin.xml
> [INFO] Adding site directory to assembly : D:\workspace_\fckeditor-java\target\s
> ite
> [INFO] Processing sources for module project: net.fckeditor:java-demo:war:2.4-SN
> APSHOT
> [INFO] Processing sources for module project: net.fckeditor:java-core:jar:2.4-SN
> APSHOT
> [INFO] Building zip: D:\workspace_\fckeditor-java\target\fckeditor-java-2.4-SNAP
> SHOT-src.zip
> [WARNING] NOTE: Currently, inclusion of module dependencies may produce unpredic
> table results if a version conflict occurs.
> [WARNING] NOTE: Currently, inclusion of module dependencies may produce unpredic
> table results if a version conflict occurs.
> [INFO] Processing DependencySet (output=lib)
> [WARNING] Cannot include project artifact: net.fckeditor:fckeditor-java:pom:2.4-
> SNAPSHOT; it doesn't have an associated file or directory.
> [INFO] Building zip: D:\workspace_\fckeditor-java\target\fckeditor-java-2.4-SNAP
> SHOT-bin.zip
> [INFO]
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] ------------------------------------------------------------------------
> [INFO] FCKeditor.Java Integration ............................ SUCCESS [32.797s]
> [INFO] FCKeditor.Java Integration Core ....................... SUCCESS [15.203s]
> [INFO] FCKeditor.Java Integration Demo Webapp ................ SUCCESS [4.609s]
> [INFO] ------------------------------------------------------------------------
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESSFUL
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1 minute 2 seconds
> [INFO] Finished at: Mon Apr 14 12:14:40 CEST 2008
> [INFO] Final Memory: 18M/33M
> [INFO] ------------------------------------------------------------------------
> D:\workspace_\fckeditor-java>
> {code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message