maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Graham (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MASSEMBLY-369) Assembly plugin process it's commands from it's pom (in addition to an external file)
Date Thu, 27 Nov 2008 01:00:19 GMT

    [ http://jira.codehaus.org/browse/MASSEMBLY-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=155554#action_155554
] 

Chris Graham commented on MASSEMBLY-369:
----------------------------------------

A little more investigation later...

Fortunately due to the classloading approach being used, we can do this:

            <plugin>
                <artifactId>maven-assembly-plugin</artifactId>
                <configuration>
                    <descriptorRefs>
                        <descriptorRef>zip-for-wid</descriptorRef>
                    </descriptorRefs>
                </configuration>
                <executions>
                    <execution>
                        <id>make-assembly</id>
                        <phase>package</phase>
                        <goals>
                            <goal>attached</goal>
                        </goals>
                    </execution>
                </executions>
                <dependencies>
                    <dependency>
                        <groupId>com.ibm.sct.maven.assemblies</groupId>
                        <artifactId>zip-for-wid</artifactId>
                        <version>0.0.1-SNAPSHOT</version>
                    </dependency>
                </dependencies>
            </plugin>

Simply declare a resource jar (which, in this case only contains assemblies\zip-for-wid.xml)
and list it as a dependency of the plugin to put it on the classpath.

This is using maven 2.0.9 (which was the first to allow this approach ???)

Whilst I'd still like the inline approach, this dependency approach is better for centralization.

-Chris


> Assembly plugin process it's commands from it's pom (in addition to an external file)
> -------------------------------------------------------------------------------------
>
>                 Key: MASSEMBLY-369
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-369
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: New Feature
>         Environment: N/A
>            Reporter: Chris Graham
>
> Currently the plugin requires an external file to get it's configuration from.
> Can we simply not have this expressed inside the pom itself?
> What we currently have:
>             <plugin>
>                 <artifactId>maven-assembly-plugin</artifactId>
>                 <configuration>
>                     <descriptors>
>                         <descriptor>assembly.xml</descriptor>
>                     </descriptors>
>                 </configuration>
>                 <executions>
>                     <execution>
>                         <id>make-assembly</id>
>                         <phase>package</phase>
>                         <goals>
>                             <goal>attached</goal>
>                         </goals>
>                     </execution>
>                 </executions>
>             </plugin>
> and assembly.xml:
> <assembly>
>     <id></id>
>     <formats>
>         <format>zip</format>
>     </formats>
>     <includeBaseDirectory>false</includeBaseDirectory>
>     <dependencySets>
>         <dependencySet>
>             <outputDirectory></outputDirectory>
>             <outputFileNameMapping></outputFileNameMapping>
>             <unpack>true</unpack>
>             <unpackOptions>
>                 <includes>
>                     <include>*.jar</include>
>                 </includes>
>             </unpackOptions>
>             <scope>runtime</scope>
>         </dependencySet>
>     </dependencySets>
> </assembly>
> What I'd like:
>             <plugin>
>                 <artifactId>maven-assembly-plugin</artifactId>
>                 <configuration>
>                     <assembly>
>                         <id></id>
>                         <formats>
>                             <format>zip</format>
>                         </formats>
>                         <includeBaseDirectory>false</includeBaseDirectory>
>                         <dependencySets>
>                             <dependencySet>
>                                 <outputDirectory></outputDirectory>
>                                 <outputFileNameMapping></outputFileNameMapping>
>                                 <unpack>true</unpack>
>                                 <unpackOptions>
>                                     <includes>
>                                         <include>*.jar</include>
>                                     </includes>
>                                 </unpackOptions>
>                                 <scope>runtime</scope>
>                             </dependencySet>
>                         </dependencySets>
>                     </assembly>
>                 </configuration>
>                 <executions>
>                     <execution>
>                         <id>make-assembly</id>
>                         <phase>package</phase>
>                         <goals>
>                             <goal>attached</goal>
>                         </goals>
>                     </execution>
>                 </executions>
>             </plugin>
> I do find it strange that it is a plugin that does *not* take it's input from a pom.
> Even a managed artifact would be fine (put assembly.xml in a resource jar and list it
as a dependency - that would also work for me).
> -Chris

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message