maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Allen (JIRA)" <j...@codehaus.org>
Subject [jira] Created: (MSHARED-83) populateModulesMenuItemsFromReactorProjects logic is incorrect, a module does not have to be a child
Date Tue, 25 Nov 2008 16:03:19 GMT
populateModulesMenuItemsFromReactorProjects logic is incorrect, a module does not have to be
a child
----------------------------------------------------------------------------------------------------

                 Key: MSHARED-83
                 URL: http://jira.codehaus.org/browse/MSHARED-83
             Project: Maven Shared Components
          Issue Type: Bug
          Components: maven-doxia-tools
    Affects Versions: maven-doxia-tools 1.0.1
            Reporter: John Allen


Some of this is my fauilt as the code in question came from some of  the patch wsork i did
on 2.0-beta-6.

Basically populateModulesMenuItemsFromReactorProjects uses the following to determine if a
project in the reactor is a module of the current project:

{code}
                if ( reactorProject != null && reactorProject.getParent() != null
                    && project.getArtifactId().equals( reactorProject.getParent().getArtifactId()
) )
{code}

This is invalid. A module != child

This needs to be changed to a check that's based upon the project's location, for that's all
we've got when it comes to determining the backref relationship of a module to its aggregator
(the enclosing project that refered to the module via a <module> element.

Patch will follow



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message