maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anders Kr. Andersen (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MNG-3845) Unintended inheritance of parent elements overriden by children
Date Wed, 19 Nov 2008 08:38:41 GMT

    [ http://jira.codehaus.org/browse/MNG-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=154702#action_154702
] 

Anders Kr. Andersen commented on MNG-3845:
------------------------------------------

Would a work-around be to specify an empty notifiers ?
Otherwise it seems correct behaviour from an overall view, because the properies are merged
to the effective pom. And it seems to work fine.

To some extend it is "you" that knows that <notifiers> goes as attributes to a kind
of key. As I understand maven, maven knows nothing about this.

> Unintended inheritance of parent elements overriden by children
> ---------------------------------------------------------------
>
>                 Key: MNG-3845
>                 URL: http://jira.codehaus.org/browse/MNG-3845
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>    Affects Versions: 3.0-alpha-1
>            Reporter: Benjamin Bentmann
>
> Parent POM snippet:
> {code:xml}
> <ciManagement>
>   <system>parent-ci</system>
>   <url>http://parent.url/ci</url>
>   <notifiers>
>     <notifier>
>       <type>irc</type>
>       <sendOnError>true</sendOnError>
>       <sendOnFailure>true</sendOnFailure>
>       <sendOnSuccess>false</sendOnSuccess>
>       <sendOnWarning>false</sendOnWarning>
>       <configuration>
>         <address>irc://parent.url/#ci</address>
>       </configuration>
>     </notifier>
>   </notifiers>
> </ciManagement>
> {code}
> Child POM snippet:
> {code:xml}
> <ciManagement>
>   <system>child-ci</system>
>   <url>http://child.url/ci</url>
> </ciManagement>
> {code}
> Effective child POM:
> {code:xml}
> <ciManagement>
>   <system>child-ci</system>
>   <url>http://child.url/ci</url>
>   <notifiers>
>     <notifier>
>       <type>irc</type>
>       <sendOnError>true</sendOnError>
>       <sendOnFailure>true</sendOnFailure>
>       <sendOnSuccess>false</sendOnSuccess>
>       <sendOnWarning>false</sendOnWarning>
>       <configuration>
>         <address>irc://parent.url/#ci</address>
>       </configuration>
>     </notifier>
>   </notifiers>
> </ciManagement>
> {code}
> i.e. the notifiers are erroneously inherited although the child has specified its own
CI management. Happens to a couple of other elements like {{<distributionManagement>}},
too. It appears the all-or-nothing style inheritance present in Maven 2.x for certain elements
is not properly emulated on trunk.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message