maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bentmann (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MJAVADOC-228) Please add support for signing javadoc jar files.
Date Mon, 30 Mar 2009 21:18:12 GMT

    [ http://jira.codehaus.org/browse/MJAVADOC-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=171455#action_171455
] 

Benjamin Bentmann commented on MJAVADOC-228:
--------------------------------------------

bq. I'll prepare a maven-signer-plugin patch to have something to start with
Great! If you already happen to be an Apache comitter, you could as well just hack in the
[Maven sandbox|http://svn.apache.org/repos/asf/maven/sandbox/trunk/plugins/] which should
be writtable to you then.

bq. Thinking about it, should such a mojo also contain the functionality of the maven-gpg-plugin

As a front note, I'm not an experienced user of either of these two plugins, so my comments
might not be well-founded. Nevertheless, I believe jarsigning and GPG - while serving a similar
purpose - are distinct tasks. The first creating a new/updated JAR, the second merely creating
a detached signature. Also, different tools with different options are involved. For these
reasons, I believe that generalizing/abstracting of these tasks would rather bring unnecessary
complexity when compared to two independent plugins, each one focusing on its particular job.
KISS.

bq. Is there already some ArtifactSigner
Not that I know of. Both the maven-jar-plugin and maven-gpg-plugin currently just end up building
the command line to execute the external tool.

bq. Provide an ArtifactSigner component in group org.apache.maven.shared.something and use
that in the plugin ?
Personally, I would just start with a single plugin. You can still design your code to have
the signing logic nicely encapsulated as a Plexus component and delegate to that from your
mojo class. But unless somebody actually calls for reusage of this signing component outside
of the context of the plugin, what's the reason to require two releases to get going?

> Please add support for signing javadoc jar files.
> -------------------------------------------------
>
>                 Key: MJAVADOC-228
>                 URL: http://jira.codehaus.org/browse/MJAVADOC-228
>             Project: Maven 2.x Javadoc Plugin
>          Issue Type: Wish
>    Affects Versions: 2.5
>         Environment: Maven version: 2.0.10
> Java version: 1.5.0_17
> OS name: "linux" version: "2.6.29" arch: "i386" Family: "unix"
>            Reporter: Christian Schulte
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message